2020-06-15 13:27:26

by Jan Kiszka

Subject: [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535

From: Jan Kiszka <[email protected]>

The PCAL9535 is compatible to the PCA9535. Additionally, it comes with
interrupt support and input latching. Other features are not supported
by the GPIO subsystem.

Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf

Signed-off-by: Jan Kiszka <[email protected]>
---
drivers/gpio/gpio-pca953x.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index 1fca8dd7824f..cd5fb522563e 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {

{ "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
{ "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
+ { "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
{ "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },

{ "max7310", 8 | PCA953X_TYPE, },
@@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {

{ .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
{ .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
+ { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
{ .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },

{ .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
--
2.26.2

2020-06-16 08:53:13

by Bartosz Golaszewski

Subject: Re: [PATCH v3 2/2] gpio: pca953x: Add support for the PCAL9535

pon., 15 cze 2020 o 15:22 Jan Kiszka <[email protected]> napisał(a):
>
> From: Jan Kiszka <[email protected]>
>
> The PCAL9535 is compatible to the PCA9535. Additionally, it comes with
> interrupt support and input latching. Other features are not supported
> by the GPIO subsystem.
>
> Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL9535A.pdf
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---
> drivers/gpio/gpio-pca953x.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 1fca8dd7824f..cd5fb522563e 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -89,6 +89,7 @@ static const struct i2c_device_id pca953x_id[] = {
>
> { "pcal6416", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
> { "pcal6524", 24 | PCA953X_TYPE | PCA_LATCH_INT, },
> + { "pcal9535", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
> { "pcal9555a", 16 | PCA953X_TYPE | PCA_LATCH_INT, },
>
> { "max7310", 8 | PCA953X_TYPE, },
> @@ -1145,6 +1146,7 @@ static const struct of_device_id pca953x_dt_ids[] = {
>
> { .compatible = "nxp,pcal6416", .data = OF_953X(16, PCA_LATCH_INT), },
> { .compatible = "nxp,pcal6524", .data = OF_953X(24, PCA_LATCH_INT), },
> + { .compatible = "nxp,pcal9535", .data = OF_953X(16, PCA_LATCH_INT), },
> { .compatible = "nxp,pcal9555a", .data = OF_953X(16, PCA_LATCH_INT), },
>
> { .compatible = "maxim,max7310", .data = OF_953X( 8, 0), },
> --
> 2.26.2
>

Patch applied with Andy's review tag.

Bart