2020-12-14 11:04:53

by Nicolai Fischer

Subject: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'

All '---help---' lines have been replaced by just 'help'.
Therefore it is no longer necessary to include '---' in the regex.

Signed-off-by: Nicolai Fischer <[email protected]>
Co-developed-by: Johannes Czekay <[email protected]>
Signed-off-by: Johannes Czekay <[email protected]>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 52f467fd32f9..5cd98f2b75f6 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3323,7 +3323,7 @@ sub process {

if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
$is_start = 1;
- } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
+ } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
$length = -1;
}

--
2.28.0

2020-12-20 19:03:50

by Joe Perches

Subject: Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'

On Mon, 2020-12-14 at 11:23 +0100, Nicolai Fischer wrote:
> All '---help---' lines have been replaced by just 'help'.
> Therefore it is no longer necessary to include '---' in the regex.
>
> Signed-off-by: Nicolai Fischer <[email protected]>
> Co-developed-by: Johannes Czekay <[email protected]>
> Signed-off-by: Johannes Czekay <[email protected]>

Acked-by: Joe Perches <[email protected]>

> ---
> ?scripts/checkpatch.pl | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 52f467fd32f9..5cd98f2b75f6 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3323,7 +3323,7 @@ sub process {
> ?
>
> ? if ($lines[$ln - 1] =~ /^\+\s*(?:bool|tristate|prompt)\s*["']/) {
> ? $is_start = 1;
> - } elsif ($lines[$ln - 1] =~ /^\+\s*(?:---)?help(?:---)?$/) {
> + } elsif ($lines[$ln - 1] =~ /^\+\s*help$/) {
> ? $length = -1;
> ? }
> ?
>

2020-12-23 01:40:12

by Andrew Morton

Subject: Re: [PATCH 1/2] checkpatch: kconfig: replace '---help---' with 'help'

On Sun, 20 Dec 2020 11:02:15 -0800 Joe Perches <[email protected]> wrote:

> On Mon, 2020-12-14 at 11:23 +0100, Nicolai Fischer wrote:
> > All '---help---' lines have been replaced by just 'help'.
> > Therefore it is no longer necessary to include '---' in the regex.
> >
> > Signed-off-by: Nicolai Fischer <[email protected]>
> > Co-developed-by: Johannes Czekay <[email protected]>
> > Signed-off-by: Johannes Czekay <[email protected]>
>
> Acked-by: Joe Perches <[email protected]>

Seems that [2/2] will be reissued. Nicolai, please cc me on the v2
series?