2017-09-25 06:52:52

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] ANDROID: binder: pr_err() strings should end with newlines

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index d055b3f..044b1c2 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2192,7 +2192,7 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,
off_start,
offp - off_start);
if (!parent) {
- pr_err("transaction release %d bad parent offset",
+ pr_err("transaction release %d bad parent offset\n",
debug_id);
continue;
}
--
1.9.1


2017-09-25 07:01:38

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] ANDROID: binder: pr_err() strings should end with newlines

On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote:
> Signed-off-by: Arvind Yadav <[email protected]>
> ---

I can't take patches without any changelog text, sorry.

greg k-h

2017-09-25 07:09:10

by Arvind Yadav

[permalink] [raw]
Subject: Re: [PATCH] ANDROID: binder: pr_err() strings should end with newlines



On Monday 25 September 2017 12:31 PM, Greg KH wrote:
> On Mon, Sep 25, 2017 at 12:21:47PM +0530, Arvind Yadav wrote:
>> Signed-off-by: Arvind Yadav <[email protected]>
>> ---
> I can't take patches without any changelog text, sorry.
As per your concern, I will update.
>
> greg k-h
~arvind