2020-07-29 17:51:10

by Matthias Kaehlcke

Subject: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

For disabled paths the 'interconnect_summary' in debugfs currently shows
the orginally requested bandwidths. This is confusing, since the bandwidth
requests aren't active. Instead show the bandwidths for disabled
paths/requests as zero.

Signed-off-by: Matthias Kaehlcke <[email protected]>
---

drivers/interconnect/core.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 609e206bf598..3491175304d1 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -55,12 +55,18 @@ static int icc_summary_show(struct seq_file *s, void *data)

icc_summary_show_one(s, n);
hlist_for_each_entry(r, &n->req_list, req_node) {
+ u32 avg_bw = 0, peak_bw = 0;
+
if (!r->dev)
continue;

+ if (r->enabled) {
+ avg_bw = r->avg_bw;
+ peak_bw = r->peak_bw;
+ }
+
seq_printf(s, " %-27s %12u %12u %12u\n",
- dev_name(r->dev), r->tag, r->avg_bw,
- r->peak_bw);
+ dev_name(r->dev), r->tag, avg_bw, peak_bw);
}
}
}
--
2.28.0.rc0.142.g3c755180ce-goog

2020-08-25 00:09:57

by Matthias Kaehlcke

Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote:
> For disabled paths the 'interconnect_summary' in debugfs currently shows
> the orginally requested bandwidths. This is confusing, since the bandwidth
> requests aren't active. Instead show the bandwidths for disabled
> paths/requests as zero.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>

ping, any comments on this?

2020-08-25 03:31:18

by Evan Green

Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

On Wed, Jul 29, 2020 at 10:50 AM Matthias Kaehlcke <[email protected]> wrote:
>
> For disabled paths the 'interconnect_summary' in debugfs currently shows
> the orginally requested bandwidths. This is confusing, since the bandwidth
> requests aren't active. Instead show the bandwidths for disabled
> paths/requests as zero.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>

Looks good to me. I briefly mulled over the idea of showing the
disabled flag as a separate column, but I can't really think of how
that would be useful.

Reviewed-by: Evan Green <[email protected]>

2020-08-27 13:42:37

by Georgi Djakov

Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs

Hi Matthias,

Thanks for the patch!

On 8/25/20 03:08, Matthias Kaehlcke wrote:
> On Wed, Jul 29, 2020 at 10:50:12AM -0700, Matthias Kaehlcke wrote:
>> For disabled paths the 'interconnect_summary' in debugfs currently shows
>> the orginally requested bandwidths. This is confusing, since the bandwidth
>> requests aren't active. Instead show the bandwidths for disabled
>> paths/requests as zero.
>>
>> Signed-off-by: Matthias Kaehlcke <[email protected]>
>
> ping, any comments on this?
>

Looks good to me! Just in case, I'll also add:
Fixes: 7d374b209083 ("interconnect: Add helpers for enabling/disabling a path")

Thanks,
Georgi