2024-03-04 23:46:42

by Damien Le Moal

Subject: Re: [PATCH v3 5/7] riscv: Kconfig.socs: Allow SOC_CANAAN with MMU for K230

On 3/5/24 06:05, Yangyu Chen wrote:
> Since K230 was released, SOC_CANAAN is no longer only referred to the K210.
> Remove it depends on !MMU will allow building dts for K230 and remove the
> K210 string from the help message.
>
> Signed-off-by: Yangyu Chen <[email protected]>
> Reviewed-by: Conor Dooley <[email protected]>
> ---
> arch/riscv/Kconfig.socs | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 623de5f8a208..b4e9b7f75510 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -75,13 +75,12 @@ config ARCH_CANAAN
> def_bool SOC_CANAAN
>
> config SOC_CANAAN
> - bool "Canaan Kendryte K210 SoC"
> - depends on !MMU

This seems wrong to me. The k210 support does require no-mmu. So why remove
this ? Does the k230 have MMU support ? If yes, then I do not think these 2 can
fall under the same SOC_CANAAN.

> + bool "Canaan Kendryte SoC"
> select CLINT_TIMER if RISCV_M_MODE
> select ARCH_HAS_RESET_CONTROLLER
> select PINCTRL
> select COMMON_CLK
> help
> - This enables support for Canaan Kendryte K210 SoC platform hardware.
> + This enables support for Canaan Kendryte SoC platform hardware.
>
> endmenu # "SoC selection"

--
Damien Le Moal
Western Digital Research

2024-03-05 10:22:15

by Yangyu Chen

Subject: Re: [PATCH v3 5/7] riscv: Kconfig.socs: Allow SOC_CANAAN with MMU for K230

On 2024/3/5 07:46, Damien Le Moal wrote:
> On 3/5/24 06:05, Yangyu Chen wrote:
>> Since K230 was released, SOC_CANAAN is no longer only referred to the K210.
>> Remove it depends on !MMU will allow building dts for K230 and remove the
>> K210 string from the help message.
>>
>> Signed-off-by: Yangyu Chen <[email protected]>
>> Reviewed-by: Conor Dooley <[email protected]>
>> ---
>> arch/riscv/Kconfig.socs | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
>> index 623de5f8a208..b4e9b7f75510 100644
>> --- a/arch/riscv/Kconfig.socs
>> +++ b/arch/riscv/Kconfig.socs
>> @@ -75,13 +75,12 @@ config ARCH_CANAAN
>> def_bool SOC_CANAAN
>>
>> config SOC_CANAAN
>> - bool "Canaan Kendryte K210 SoC"
>> - depends on !MMU
>
> This seems wrong to me. The k210 support does require no-mmu. So why remove
> this ?

It just allows SOC_CANAAN to be selected when MMU=y. With this patch,
nommu_k210_defconfig still works.

> Does the k230 have MMU support ? If yes, then I do not think these 2 can
> fall under the same SOC_CANAAN.
>

Yes, K230 has MMU, you can see the bootlog from the cover letter and the
dts patch [6/7]. Could you provide some reasons why it can fall? I
didn't see any differences in .config after this change after executing
'make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- nommu_k210_defconfig'.

>> + bool "Canaan Kendryte SoC"
>> select CLINT_TIMER if RISCV_M_MODE
>> select ARCH_HAS_RESET_CONTROLLER
>> select PINCTRL
>> select COMMON_CLK
>> help
>> - This enables support for Canaan Kendryte K210 SoC platform hardware.
>> + This enables support for Canaan Kendryte SoC platform hardware.
>>
>> endmenu # "SoC selection"
>