2022-06-08 08:49:46

by Cheng Xu

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/erdma: remove unneeded semicolon



On 6/8/22 8:55 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Cheng Xu <[email protected]>

Thanks.


Jason,

BTW, are this and other two patches for erdma posted today parts of
the static checker reports which you mentioned in [1] ? If so, I think I
should re-post the v10 patches including the fixes ?

Thanks,
Cheng Xu

[1] https://lore.kernel.org/linux-rdma/[email protected]/


2022-06-08 09:11:00

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/erdma: remove unneeded semicolon

On Wed, Jun 08, 2022 at 11:36:07AM +0800, Cheng Xu wrote:
>
>
> On 6/8/22 8:55 AM, Yang Li wrote:
> > Eliminate the following coccicheck warning:
> > ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Cheng Xu <[email protected]>
>
> Thanks.
>
>
> Jason,
>
> BTW, are this and other two patches for erdma posted today parts of
> the static checker reports which you mentioned in [1] ? If so, I think I
> should re-post the v10 patches including the fixes ?

Yes, the fixes need to be squashed into the relevant patches.

Thanks

>
> Thanks,
> Cheng Xu
>
> [1] https://lore.kernel.org/linux-rdma/[email protected]/

2022-06-08 12:18:07

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: [PATCH -next] RDMA/erdma: remove unneeded semicolon

On Wed, Jun 08, 2022 at 11:36:07AM +0800, Cheng Xu wrote:
>
>
> On 6/8/22 8:55 AM, Yang Li wrote:
> > Eliminate the following coccicheck warning:
> > ./drivers/infiniband/hw/erdma/erdma_qp.c:254:3-4: Unneeded semicolon
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Cheng Xu <[email protected]>
>
> Thanks.
>
>
> Jason,
>
> BTW, are this and other two patches for erdma posted today parts of
> the static checker reports which you mentioned in [1] ? If so, I think I
> should re-post the v10 patches including the fixes ?

Yes, and I would wait for a week or so because this is just the first
day.

Jason