2014-12-11 10:15:57

by Cyrille Pitchen

Subject: [PATCH 1/1] net/macb: fix compilation warning for print_hex_dump() called with skb->mac_header

Signed-off-by: Cyrille Pitchen <[email protected]>
---
drivers/net/ethernet/cadence/macb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 41113e5..9ddc9bf 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -776,7 +776,7 @@ static int gem_rx(struct macb *bp, int budget)
netdev_vdbg(bp->dev, "received skb of length %u, csum: %08x\n",
skb->len, skb->csum);
print_hex_dump(KERN_DEBUG, " mac: ", DUMP_PREFIX_ADDRESS, 16, 1,
- skb->mac_header, 16, true);
+ skb_mac_header(skb), 16, true);
print_hex_dump(KERN_DEBUG, "data: ", DUMP_PREFIX_ADDRESS, 16, 1,
skb->data, 32, true);
#endif
--
1.8.2.2

2014-12-11 14:40:04

by Sergei Shtylyov

Subject: Re: [PATCH 1/1] net/macb: fix compilation warning for print_hex_dump() called with skb->mac_header

Hello.

On 12/11/2014 1:15 PM, Cyrille Pitchen wrote:

Citing the warning here would be a good idea.

> Signed-off-by: Cyrille Pitchen <[email protected]>

WBR, Sergei

2014-12-11 19:52:31

by David Miller

Subject: Re: [PATCH 1/1] net/macb: fix compilation warning for print_hex_dump() called with skb->mac_header

From: Cyrille Pitchen <[email protected]>
Date: Thu, 11 Dec 2014 11:15:54 +0100

> Signed-off-by: Cyrille Pitchen <[email protected]>

Applied, thanks.