BugLink: http://bugs.launchpad.net/bugs/1217957
Add quirk for Dell SP2008WFP monitor: 05a9:2641
Signed-off-by: Joseph Salisbury <[email protected]>
Tested-by: Christopher Townsend <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index ed123f4..8c1826c 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2174,6 +2174,15 @@ static struct usb_device_id uvc_ids[] = {
.bInterfaceSubClass = 1,
.bInterfaceProtocol = 0,
.driver_info = UVC_QUIRK_PROBE_DEF },
+ /* Dell SP2008WFP Monitor */
+ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
+ | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x05a9,
+ .idProduct = 0x2641,
+ .bInterfaceClass = USB_CLASS_VIDEO,
+ .bInterfaceSubClass = 1,
+ .bInterfaceProtocol = 0,
+ .driver_info = UVC_QUIRK_PROBE_DEF },
/* Dell Alienware X51 */
{ .match_flags = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
--
1.7.9.5
Hi Joseph,
Thank you for the patch.
On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> BugLink: http://bugs.launchpad.net/bugs/1217957
>
> Add quirk for Dell SP2008WFP monitor: 05a9:2641
>
> Signed-off-by: Joseph Salisbury <[email protected]>
> Tested-by: Christopher Townsend <[email protected]>
> Cc: Laurent Pinchart <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
Acked-by: Laurent Pinchart <[email protected]>
I've applied it to my tree. Given that we're too close to the v3.12 merge
window I will push it for v3.13.
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index ed123f4..8c1826c 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2174,6 +2174,15 @@ static struct usb_device_id uvc_ids[] = {
> .bInterfaceSubClass = 1,
> .bInterfaceProtocol = 0,
> .driver_info = UVC_QUIRK_PROBE_DEF },
> + /* Dell SP2008WFP Monitor */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x05a9,
> + .idProduct = 0x2641,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_QUIRK_PROBE_DEF },
> /* Dell Alienware X51 */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>
> | USB_DEVICE_ID_MATCH_INT_INFO,
--
Regards,
Laurent Pinchart
On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> Hi Joseph,
>
> Thank you for the patch.
>
> On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > BugLink: http://bugs.launchpad.net/bugs/1217957
> >
> > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> >
> > Signed-off-by: Joseph Salisbury <[email protected]>
> > Tested-by: Christopher Townsend <[email protected]>
> > Cc: Laurent Pinchart <[email protected]>
> > Cc: Mauro Carvalho Chehab <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Cc: [email protected]
>
> Acked-by: Laurent Pinchart <[email protected]>
>
> I've applied it to my tree. Given that we're too close to the v3.12 merge
> window I will push it for v3.13.
A quirk has to wait that long? That's not ok, they should go in much
sooner than that...
thanks,
greg k-h
Hi Greg,
On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > >
> > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > >
> > > Signed-off-by: Joseph Salisbury <[email protected]>
> > > Tested-by: Christopher Townsend <[email protected]>
> > > Cc: Laurent Pinchart <[email protected]>
> > > Cc: Mauro Carvalho Chehab <[email protected]>
> > > Cc: [email protected]
> > > Cc: [email protected]
> > > Cc: [email protected]
> >
> > Acked-by: Laurent Pinchart <[email protected]>
> >
> > I've applied it to my tree. Given that we're too close to the v3.12 merge
> > window I will push it for v3.13.
>
> A quirk has to wait that long? That's not ok, they should go in much
> sooner than that...
Can such a patch get merged during the -rc phase ? If so I will push it to
v3.12.
--
Regards,
Laurent Pinchart
On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote:
> Hi Greg,
>
> On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > > >
> > > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > > >
> > > > Signed-off-by: Joseph Salisbury <[email protected]>
> > > > Tested-by: Christopher Townsend <[email protected]>
> > > > Cc: Laurent Pinchart <[email protected]>
> > > > Cc: Mauro Carvalho Chehab <[email protected]>
> > > > Cc: [email protected]
> > > > Cc: [email protected]
> > > > Cc: [email protected]
> > >
> > > Acked-by: Laurent Pinchart <[email protected]>
> > >
> > > I've applied it to my tree. Given that we're too close to the v3.12 merge
> > > window I will push it for v3.13.
> >
> > A quirk has to wait that long? That's not ok, they should go in much
> > sooner than that...
>
> Can such a patch get merged during the -rc phase ? If so I will push it to
> v3.12.
Yes it can, and it should also be merged to stable releases, as the cc:
stable shows.
thanks,
greg k-h
Hi Greg,
On Friday 30 August 2013 09:39:58 Greg KH wrote:
> On Fri, Aug 30, 2013 at 12:28:16PM +0200, Laurent Pinchart wrote:
> > On Thursday 29 August 2013 21:00:21 Greg KH wrote:
> > > On Fri, Aug 30, 2013 at 02:41:17AM +0200, Laurent Pinchart wrote:
> > > > On Thursday 29 August 2013 11:17:41 Joseph Salisbury wrote:
> > > > > BugLink: http://bugs.launchpad.net/bugs/1217957
> > > > >
> > > > > Add quirk for Dell SP2008WFP monitor: 05a9:2641
> > > > >
> > > > > Signed-off-by: Joseph Salisbury <[email protected]>
> > > > > Tested-by: Christopher Townsend <[email protected]>
> > > > > Cc: Laurent Pinchart <[email protected]>
> > > > > Cc: Mauro Carvalho Chehab <[email protected]>
> > > > > Cc: [email protected]
> > > > > Cc: [email protected]
> > > > > Cc: [email protected]
> > > >
> > > > Acked-by: Laurent Pinchart <[email protected]>
> > > >
> > > > I've applied it to my tree. Given that we're too close to the v3.12
> > > > merge window I will push it for v3.13.
> > >
> > > A quirk has to wait that long? That's not ok, they should go in much
> > > sooner than that...
> >
> > Can such a patch get merged during the -rc phase ? If so I will push it to
> > v3.12.
>
> Yes it can,
OK, I'll send a pull request to Mauro right after the v3.12 merge window
closes, as he's pretty busy with pending pull requests for v3.12 at the
moment.
> and it should also be merged to stable releases, as the cc: stable shows.
Sure, that was my plan.
--
Regards,
Laurent Pinchart