2023-11-06 02:34:25

by Jiapeng Chong

Subject: [PATCH] bcachefs: make bch2_target_to_text_sb static

The bch2_target_to_text_sb are not used outside the file disk_groups.c,
so the modification is defined as static.

fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for ‘bch2_target_to_text_sb’.

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7144
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/bcachefs/disk_groups.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/disk_groups.c b/fs/bcachefs/disk_groups.c
index d613695abf9f..1f334124055b 100644
--- a/fs/bcachefs/disk_groups.c
+++ b/fs/bcachefs/disk_groups.c
@@ -580,7 +580,7 @@ void bch2_target_to_text(struct printbuf *out, struct bch_fs *c, unsigned v)
}
}

-void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v)
+static void bch2_target_to_text_sb(struct printbuf *out, struct bch_sb *sb, unsigned v)
{
struct target t = target_decode(v);

--
2.20.1.7.g153144c

2023-11-06 03:08:22

by Kent Overstreet

Subject: Re: [PATCH] bcachefs: make bch2_target_to_text_sb static

On Mon, Nov 06, 2023 at 10:34:01AM +0800, Jiapeng Chong wrote:
> The bch2_target_to_text_sb are not used outside the file disk_groups.c,
> so the modification is defined as static.
>
> fs/bcachefs/disk_groups.c:583:6: warning: no previous prototype for ‘bch2_target_to_text_sb’.
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7144
> Signed-off-by: Jiapeng Chong <[email protected]>

Thanks, applied