2023-02-10 09:34:13

by Bin Meng

[permalink] [raw]
Subject: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

Drop CONFIG_MTD_M25P80 that was removed in
commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")

Signed-off-by: Bin Meng <[email protected]>

---

arch/arm/configs/axm55xx_defconfig | 2 +-
arch/arm/configs/davinci_all_defconfig | 1 -
arch/arm/configs/dove_defconfig | 1 -
arch/arm/configs/keystone_defconfig | 1 -
arch/arm/configs/mvebu_v5_defconfig | 1 -
arch/arm/configs/mxs_defconfig | 1 -
arch/arm/configs/pxa_defconfig | 1 -
arch/arm/configs/qcom_defconfig | 1 -
arch/arm/configs/socfpga_defconfig | 1 -
9 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
index bfbaa2df3be5..936aecbdc129 100644
--- a/arch/arm/configs/axm55xx_defconfig
+++ b/arch/arm/configs/axm55xx_defconfig
@@ -85,7 +85,7 @@ CONFIG_MTD_CFI_AMDSTD=y
CONFIG_MTD_CFI_STAA=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PHYSMAP_OF=y
-CONFIG_MTD_M25P80=y
+CONFIG_MTD_SPI_NOR=y
CONFIG_PROC_DEVICETREE=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
index 821d966c95a5..cb7a03bce291 100644
--- a/arch/arm/configs/davinci_all_defconfig
+++ b/arch/arm/configs/davinci_all_defconfig
@@ -63,7 +63,6 @@ CONFIG_MTD_CFI=m
CONFIG_MTD_CFI_INTELEXT=m
CONFIG_MTD_CFI_AMDSTD=m
CONFIG_MTD_PHYSMAP=m
-CONFIG_MTD_M25P80=m
CONFIG_MTD_RAW_NAND=m
CONFIG_MTD_NAND_DAVINCI=m
CONFIG_MTD_SPI_NOR=m
diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig
index ff37f46c82fb..3f90b4b241a9 100644
--- a/arch/arm/configs/dove_defconfig
+++ b/arch/arm/configs/dove_defconfig
@@ -43,7 +43,6 @@ CONFIG_MTD_CFI_GEOMETRY=y
CONFIG_MTD_CFI_INTELEXT=y
CONFIG_MTD_CFI_STAA=y
CONFIG_MTD_PHYSMAP=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_SPI_NOR=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
index 4a5b9adbf2a1..36692143dd3d 100644
--- a/arch/arm/configs/keystone_defconfig
+++ b/arch/arm/configs/keystone_defconfig
@@ -118,7 +118,6 @@ CONFIG_MTD=y
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_PLATRAM=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_DAVINCI=y
CONFIG_MTD_SPI_NOR=y
diff --git a/arch/arm/configs/mvebu_v5_defconfig b/arch/arm/configs/mvebu_v5_defconfig
index 2467afd32146..26c5724c409d 100644
--- a/arch/arm/configs/mvebu_v5_defconfig
+++ b/arch/arm/configs/mvebu_v5_defconfig
@@ -63,7 +63,6 @@ CONFIG_MTD_CFI_GEOMETRY=y
CONFIG_MTD_CFI_INTELEXT=y
CONFIG_MTD_CFI_STAA=y
CONFIG_MTD_PHYSMAP=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_ORION=y
CONFIG_MTD_SPI_NOR=y
diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
index feb38a94c1a7..0eeef6402952 100644
--- a/arch/arm/configs/mxs_defconfig
+++ b/arch/arm/configs/mxs_defconfig
@@ -45,7 +45,6 @@ CONFIG_MTD=y
CONFIG_MTD_CMDLINE_PARTS=y
CONFIG_MTD_BLOCK=y
CONFIG_MTD_DATAFLASH=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_SST25L=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_GPMI_NAND=y
diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
index 0a0f12df40b5..851a817b52c0 100644
--- a/arch/arm/configs/pxa_defconfig
+++ b/arch/arm/configs/pxa_defconfig
@@ -130,7 +130,6 @@ CONFIG_MTD_ROM=m
CONFIG_MTD_COMPLEX_MAPPINGS=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PXA2XX=m
-CONFIG_MTD_M25P80=m
CONFIG_MTD_BLOCK2MTD=y
CONFIG_MTD_DOCG3=m
CONFIG_MTD_ONENAND=m
diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index b41716c1ec64..fd5581edc310 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -63,7 +63,6 @@ CONFIG_DEVTMPFS_MOUNT=y
CONFIG_MTD=y
CONFIG_MTD_QCOMSMEM_PARTS=y
CONFIG_MTD_BLOCK=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_QCOM=y
CONFIG_MTD_SPI_NOR=y
diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
index 70739e09d0f4..9591af0441dd 100644
--- a/arch/arm/configs/socfpga_defconfig
+++ b/arch/arm/configs/socfpga_defconfig
@@ -41,7 +41,6 @@ CONFIG_DEVTMPFS=y
CONFIG_DEVTMPFS_MOUNT=y
CONFIG_MTD=y
CONFIG_MTD_BLOCK=y
-CONFIG_MTD_M25P80=y
CONFIG_MTD_RAW_NAND=y
CONFIG_MTD_NAND_DENALI_DT=y
CONFIG_MTD_SPI_NOR=y
--
2.25.1



2023-02-23 10:48:19

by Bin Meng

[permalink] [raw]
Subject: Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

On 2023/2/10 17:32:24, "Bin Meng" <[email protected]> wrote:

>Drop CONFIG_MTD_M25P80 that was removed in
>commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
>
>Signed-off-by: Bin Meng <[email protected]>
>
>---
>
> arch/arm/configs/axm55xx_defconfig | 2 +-
> arch/arm/configs/davinci_all_defconfig | 1 -
> arch/arm/configs/dove_defconfig | 1 -
> arch/arm/configs/keystone_defconfig | 1 -
> arch/arm/configs/mvebu_v5_defconfig | 1 -
> arch/arm/configs/mxs_defconfig | 1 -
> arch/arm/configs/pxa_defconfig | 1 -
> arch/arm/configs/qcom_defconfig | 1 -
> arch/arm/configs/socfpga_defconfig | 1 -
> 9 files changed, 1 insertion(+), 9 deletions(-)
>
>

Ping?

2023-02-23 10:49:50

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files



On 10.02.2023 10:32, Bin Meng wrote:
> Drop CONFIG_MTD_M25P80 that was removed in
> commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
>
> Signed-off-by: Bin Meng <[email protected]>
>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> arch/arm/configs/axm55xx_defconfig | 2 +-
> arch/arm/configs/davinci_all_defconfig | 1 -
> arch/arm/configs/dove_defconfig | 1 -
> arch/arm/configs/keystone_defconfig | 1 -
> arch/arm/configs/mvebu_v5_defconfig | 1 -
> arch/arm/configs/mxs_defconfig | 1 -
> arch/arm/configs/pxa_defconfig | 1 -
> arch/arm/configs/qcom_defconfig | 1 -
> arch/arm/configs/socfpga_defconfig | 1 -
> 9 files changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/arm/configs/axm55xx_defconfig b/arch/arm/configs/axm55xx_defconfig
> index bfbaa2df3be5..936aecbdc129 100644
> --- a/arch/arm/configs/axm55xx_defconfig
> +++ b/arch/arm/configs/axm55xx_defconfig
> @@ -85,7 +85,7 @@ CONFIG_MTD_CFI_AMDSTD=y
> CONFIG_MTD_CFI_STAA=y
> CONFIG_MTD_PHYSMAP=y
> CONFIG_MTD_PHYSMAP_OF=y
> -CONFIG_MTD_M25P80=y
> +CONFIG_MTD_SPI_NOR=y
> CONFIG_PROC_DEVICETREE=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_RAM=y
> diff --git a/arch/arm/configs/davinci_all_defconfig b/arch/arm/configs/davinci_all_defconfig
> index 821d966c95a5..cb7a03bce291 100644
> --- a/arch/arm/configs/davinci_all_defconfig
> +++ b/arch/arm/configs/davinci_all_defconfig
> @@ -63,7 +63,6 @@ CONFIG_MTD_CFI=m
> CONFIG_MTD_CFI_INTELEXT=m
> CONFIG_MTD_CFI_AMDSTD=m
> CONFIG_MTD_PHYSMAP=m
> -CONFIG_MTD_M25P80=m
> CONFIG_MTD_RAW_NAND=m
> CONFIG_MTD_NAND_DAVINCI=m
> CONFIG_MTD_SPI_NOR=m
> diff --git a/arch/arm/configs/dove_defconfig b/arch/arm/configs/dove_defconfig
> index ff37f46c82fb..3f90b4b241a9 100644
> --- a/arch/arm/configs/dove_defconfig
> +++ b/arch/arm/configs/dove_defconfig
> @@ -43,7 +43,6 @@ CONFIG_MTD_CFI_GEOMETRY=y
> CONFIG_MTD_CFI_INTELEXT=y
> CONFIG_MTD_CFI_STAA=y
> CONFIG_MTD_PHYSMAP=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_SPI_NOR=y
> CONFIG_BLK_DEV_LOOP=y
> CONFIG_BLK_DEV_RAM=y
> diff --git a/arch/arm/configs/keystone_defconfig b/arch/arm/configs/keystone_defconfig
> index 4a5b9adbf2a1..36692143dd3d 100644
> --- a/arch/arm/configs/keystone_defconfig
> +++ b/arch/arm/configs/keystone_defconfig
> @@ -118,7 +118,6 @@ CONFIG_MTD=y
> CONFIG_MTD_CMDLINE_PARTS=y
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_PLATRAM=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_RAW_NAND=y
> CONFIG_MTD_NAND_DAVINCI=y
> CONFIG_MTD_SPI_NOR=y
> diff --git a/arch/arm/configs/mvebu_v5_defconfig b/arch/arm/configs/mvebu_v5_defconfig
> index 2467afd32146..26c5724c409d 100644
> --- a/arch/arm/configs/mvebu_v5_defconfig
> +++ b/arch/arm/configs/mvebu_v5_defconfig
> @@ -63,7 +63,6 @@ CONFIG_MTD_CFI_GEOMETRY=y
> CONFIG_MTD_CFI_INTELEXT=y
> CONFIG_MTD_CFI_STAA=y
> CONFIG_MTD_PHYSMAP=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_RAW_NAND=y
> CONFIG_MTD_NAND_ORION=y
> CONFIG_MTD_SPI_NOR=y
> diff --git a/arch/arm/configs/mxs_defconfig b/arch/arm/configs/mxs_defconfig
> index feb38a94c1a7..0eeef6402952 100644
> --- a/arch/arm/configs/mxs_defconfig
> +++ b/arch/arm/configs/mxs_defconfig
> @@ -45,7 +45,6 @@ CONFIG_MTD=y
> CONFIG_MTD_CMDLINE_PARTS=y
> CONFIG_MTD_BLOCK=y
> CONFIG_MTD_DATAFLASH=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_SST25L=y
> CONFIG_MTD_RAW_NAND=y
> CONFIG_MTD_NAND_GPMI_NAND=y
> diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
> index 0a0f12df40b5..851a817b52c0 100644
> --- a/arch/arm/configs/pxa_defconfig
> +++ b/arch/arm/configs/pxa_defconfig
> @@ -130,7 +130,6 @@ CONFIG_MTD_ROM=m
> CONFIG_MTD_COMPLEX_MAPPINGS=y
> CONFIG_MTD_PHYSMAP=y
> CONFIG_MTD_PXA2XX=m
> -CONFIG_MTD_M25P80=m
> CONFIG_MTD_BLOCK2MTD=y
> CONFIG_MTD_DOCG3=m
> CONFIG_MTD_ONENAND=m
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index b41716c1ec64..fd5581edc310 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -63,7 +63,6 @@ CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_MTD=y
> CONFIG_MTD_QCOMSMEM_PARTS=y
> CONFIG_MTD_BLOCK=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_RAW_NAND=y
> CONFIG_MTD_NAND_QCOM=y
> CONFIG_MTD_SPI_NOR=y
> diff --git a/arch/arm/configs/socfpga_defconfig b/arch/arm/configs/socfpga_defconfig
> index 70739e09d0f4..9591af0441dd 100644
> --- a/arch/arm/configs/socfpga_defconfig
> +++ b/arch/arm/configs/socfpga_defconfig
> @@ -41,7 +41,6 @@ CONFIG_DEVTMPFS=y
> CONFIG_DEVTMPFS_MOUNT=y
> CONFIG_MTD=y
> CONFIG_MTD_BLOCK=y
> -CONFIG_MTD_M25P80=y
> CONFIG_MTD_RAW_NAND=y
> CONFIG_MTD_NAND_DENALI_DT=y
> CONFIG_MTD_SPI_NOR=y

2023-02-23 10:50:52

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

On 23/02/2023 11:46, Bin Meng wrote:
> On 2023/2/10 17:32:24, "Bin Meng" <[email protected]> wrote:
>
>> Drop CONFIG_MTD_M25P80 that was removed in
>> commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
>>
>> Signed-off-by: Bin Meng <[email protected]>
>>
>> ---
>>
>> arch/arm/configs/axm55xx_defconfig | 2 +-
>> arch/arm/configs/davinci_all_defconfig | 1 -
>> arch/arm/configs/dove_defconfig | 1 -
>> arch/arm/configs/keystone_defconfig | 1 -
>> arch/arm/configs/mvebu_v5_defconfig | 1 -
>> arch/arm/configs/mxs_defconfig | 1 -
>> arch/arm/configs/pxa_defconfig | 1 -
>> arch/arm/configs/qcom_defconfig | 1 -
>> arch/arm/configs/socfpga_defconfig | 1 -
>> 9 files changed, 1 insertion(+), 9 deletions(-)
>>
>>
>
> Ping?

No need for pinging, but you need to send to soc folks. Otherwise no one
will pick it up. You will get the address from get_maintainer.pl -f
arch/arm/boot/dts/Makefile (yes, it is quite hidden on purpose).

Best regards,
Krzysztof


2023-02-23 11:01:25

by Bin Meng

[permalink] [raw]
Subject: Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

On 2023/2/23 18:50:36, "Krzysztof Kozlowski"
<[email protected]> wrote:

>On 23/02/2023 11:46, Bin Meng wrote:
>> On 2023/2/10 17:32:24, "Bin Meng" <[email protected]> wrote:
>>
>>> Drop CONFIG_MTD_M25P80 that was removed in
>>> commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
>>>
>>> Signed-off-by: Bin Meng <[email protected]>
>>>
>>> ---
>>>
>>> arch/arm/configs/axm55xx_defconfig | 2 +-
>>> arch/arm/configs/davinci_all_defconfig | 1 -
>>> arch/arm/configs/dove_defconfig | 1 -
>>> arch/arm/configs/keystone_defconfig | 1 -
>>> arch/arm/configs/mvebu_v5_defconfig | 1 -
>>> arch/arm/configs/mxs_defconfig | 1 -
>>> arch/arm/configs/pxa_defconfig | 1 -
>>> arch/arm/configs/qcom_defconfig | 1 -
>>> arch/arm/configs/socfpga_defconfig | 1 -
>>> 9 files changed, 1 insertion(+), 9 deletions(-)
>>>
>>>
>>
>> Ping?
>
>No need for pinging, but you need to send to soc folks. Otherwise no one
>will pick it up. You will get the address from get_maintainer.pl -f
>arch/arm/boot/dts/Makefile (yes, it is quite hidden on purpose).

Yeah I used the script to generate the cc list.

Let me know if I need to split this patch into several ones (per-soc a
patch) so that each soc maintainer only picks up their own?

Regards,
Bin

2023-02-23 11:15:41

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm: Drop CONFIG_MTD_M25P80 in various defconfig files

On 23/02/2023 12:00, Bin Meng wrote:
> On 2023/2/23 18:50:36, "Krzysztof Kozlowski"
> <[email protected]> wrote:
>
>> On 23/02/2023 11:46, Bin Meng wrote:
>>> On 2023/2/10 17:32:24, "Bin Meng" <[email protected]> wrote:
>>>
>>>> Drop CONFIG_MTD_M25P80 that was removed in
>>>> commit b35b9a10362d ("mtd: spi-nor: Move m25p80 code in spi-nor.c")
>>>>
>>>> Signed-off-by: Bin Meng <[email protected]>
>>>>
>>>> ---
>>>>
>>>> arch/arm/configs/axm55xx_defconfig | 2 +-
>>>> arch/arm/configs/davinci_all_defconfig | 1 -
>>>> arch/arm/configs/dove_defconfig | 1 -
>>>> arch/arm/configs/keystone_defconfig | 1 -
>>>> arch/arm/configs/mvebu_v5_defconfig | 1 -
>>>> arch/arm/configs/mxs_defconfig | 1 -
>>>> arch/arm/configs/pxa_defconfig | 1 -
>>>> arch/arm/configs/qcom_defconfig | 1 -
>>>> arch/arm/configs/socfpga_defconfig | 1 -
>>>> 9 files changed, 1 insertion(+), 9 deletions(-)
>>>>
>>>>
>>>
>>> Ping?
>>
>> No need for pinging, but you need to send to soc folks. Otherwise no one
>> will pick it up. You will get the address from get_maintainer.pl -f
>> arch/arm/boot/dts/Makefile (yes, it is quite hidden on purpose).
>
> Yeah I used the script to generate the cc list.

Did you read my message fully? Because the CC list is not having the
proper address, thus maybe you based your patch on some old kernel.
Please rebase.

>
> Let me know if I need to split this patch into several ones (per-soc a
> patch) so that each soc maintainer only picks up their own?

If you did what I wrote about and the kernel is fairly recent, then no
need...


Best regards,
Krzysztof