2018-01-21 19:46:45

by SF Markus Elfring

Subject: [PATCH 0/2] Input: da9034-ts: Adjustments for da9034_touch_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 20:42:24 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/touchscreen/da9034-ts.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

--
2.16.0

2018-01-21 19:48:06

by SF Markus Elfring

Subject: [PATCH 1/2] Input: da9034-ts: Delete an error message for a failed memory allocation in da9034_touch_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 20:32:48 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/da9034-ts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/da9034-ts.c b/drivers/input/touchscreen/da9034-ts.c
index 8264822dc4b9..b30cfe1e62da 100644
--- a/drivers/input/touchscreen/da9034-ts.c
+++ b/drivers/input/touchscreen/da9034-ts.c
@@ -305,10 +305,8 @@ static int da9034_touch_probe(struct platform_device *pdev)

touch = devm_kzalloc(&pdev->dev, sizeof(struct da9034_touch),
GFP_KERNEL);
- if (!touch) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (!touch)
return -ENOMEM;
- }

touch->da9034_dev = pdev->dev.parent;

--
2.16.0

2018-01-21 19:49:50

by SF Markus Elfring

Subject: [PATCH 2/2] Input: da9034-ts: Improve a size determination in da9034_touch_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 20:36:20 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/da9034-ts.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/da9034-ts.c b/drivers/input/touchscreen/da9034-ts.c
index b30cfe1e62da..c9c423aebe1e 100644
--- a/drivers/input/touchscreen/da9034-ts.c
+++ b/drivers/input/touchscreen/da9034-ts.c
@@ -303,8 +303,7 @@ static int da9034_touch_probe(struct platform_device *pdev)
struct input_dev *input_dev;
int error;

- touch = devm_kzalloc(&pdev->dev, sizeof(struct da9034_touch),
- GFP_KERNEL);
+ touch = devm_kzalloc(&pdev->dev, sizeof(*touch), GFP_KERNEL);
if (!touch)
return -ENOMEM;

--
2.16.0