The powerpc section has a "F:" entry for drivers/macintosh, matching all
files in or below drivers/macintosh. That is correct for the most part,
but there are a couple of m68k-only drivers in the directory, so exclude
those.
Signed-off-by: Michael Ellerman <[email protected]>
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 250518fc70ff..9bbb613d386a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11916,6 +11916,8 @@ L: [email protected]
S: Odd Fixes
F: arch/powerpc/platforms/powermac/
F: drivers/macintosh/
+X: drivers/macintosh/adb-iop.c
+X: drivers/macintosh/via-macii.c
LINUX FOR POWERPC (32-BIT AND 64-BIT)
M: Michael Ellerman <[email protected]>
--
2.40.1
Hi Michael,
CC Finn
On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <[email protected]> wrote:
> The powerpc section has a "F:" entry for drivers/macintosh, matching all
> files in or below drivers/macintosh. That is correct for the most part,
> but there are a couple of m68k-only drivers in the directory, so exclude
> those.
>
> Signed-off-by: Michael Ellerman <[email protected]>
Thanks for your patch!
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11916,6 +11916,8 @@ L: [email protected]
> S: Odd Fixes
> F: arch/powerpc/platforms/powermac/
> F: drivers/macintosh/
> +X: drivers/macintosh/adb-iop.c
> +X: drivers/macintosh/via-macii.c
>
> LINUX FOR POWERPC (32-BIT AND 64-BIT)
> M: Michael Ellerman <[email protected]>
LGTM, as there are already entries for these two files under
"M68K ON APPLE MACINTOSH".
Acked-by: Geert Uytterhoeven <[email protected]>
Which leads us to a related topic: Is Joshua still around? Should Finn
be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
On 1/06/23 00:59, Geert Uytterhoeven wrote:
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11916,6 +11916,8 @@ L: [email protected]
>> S: Odd Fixes
>> F: arch/powerpc/platforms/powermac/
>> F: drivers/macintosh/
>> +X: drivers/macintosh/adb-iop.c
>> +X: drivers/macintosh/via-macii.c
>>
>> LINUX FOR POWERPC (32-BIT AND 64-BIT)
>> M: Michael Ellerman <[email protected]>
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".
> Acked-by: Geert Uytterhoeven <[email protected]>
>
> Which leads us to a related topic: Is Joshua still around? Should Finn
> be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?
Add Finn, at the very least (if he's agreed). Haven't seen mail from
Joshua in the past 13 years myself.
Cheers,
Michael
>
> Gr{oetje,eeting}s,
>
> Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
On Wed, 31 May 2023, Geert Uytterhoeven wrote:
> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <[email protected]> wrote:
> > The powerpc section has a "F:" entry for drivers/macintosh, matching
> > all files in or below drivers/macintosh. That is correct for the most
> > part, but there are a couple of m68k-only drivers in the directory, so
> > exclude those.
> >
> > Signed-off-by: Michael Ellerman <[email protected]>
>
> Thanks for your patch!
>
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11916,6 +11916,8 @@ L: [email protected]
> > S: Odd Fixes
> > F: arch/powerpc/platforms/powermac/
> > F: drivers/macintosh/
> > +X: drivers/macintosh/adb-iop.c
> > +X: drivers/macintosh/via-macii.c
> >
> > LINUX FOR POWERPC (32-BIT AND 64-BIT)
> > M: Michael Ellerman <[email protected]>
>
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".
Right. I should have addded those "X files" in commit 2ae92e8b9b7.
> Acked-by: Geert Uytterhoeven <[email protected]>
>
> Which leads us to a related topic: Is Joshua still around? Should Finn
> be added or replace Joshua in the "M68K ON APPLE MACINTOSH" entry?
>
CC Joshua.
If he's not around perhaps we'll see some bounces.
Anyway, I'd be willing to either share the M68K ON APPLE MACINTOSH role or
replace Joshua if he no longer wants that job.
But I hope he does still want it as there's always driver work to do.
Geert Uytterhoeven <[email protected]> writes:
> Hi Michael,
>
> CC Finn
>
> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <[email protected]> wrote:
>> The powerpc section has a "F:" entry for drivers/macintosh, matching all
>> files in or below drivers/macintosh. That is correct for the most part,
>> but there are a couple of m68k-only drivers in the directory, so exclude
>> those.
>>
>> Signed-off-by: Michael Ellerman <[email protected]>
>
> Thanks for your patch!
>
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -11916,6 +11916,8 @@ L: [email protected]
>> S: Odd Fixes
>> F: arch/powerpc/platforms/powermac/
>> F: drivers/macintosh/
>> +X: drivers/macintosh/adb-iop.c
>> +X: drivers/macintosh/via-macii.c
>>
>> LINUX FOR POWERPC (32-BIT AND 64-BIT)
>> M: Michael Ellerman <[email protected]>
>
> LGTM, as there are already entries for these two files under
> "M68K ON APPLE MACINTOSH".
> Acked-by: Geert Uytterhoeven <[email protected]>
Thanks.
cheers
Finn Thain <[email protected]> writes:
> On Wed, 31 May 2023, Geert Uytterhoeven wrote:
>> On Wed, May 31, 2023 at 2:50 PM Michael Ellerman <[email protected]> wrote:
>> > The powerpc section has a "F:" entry for drivers/macintosh, matching
>> > all files in or below drivers/macintosh. That is correct for the most
>> > part, but there are a couple of m68k-only drivers in the directory, so
>> > exclude those.
>> >
>> > Signed-off-by: Michael Ellerman <[email protected]>
>>
>> Thanks for your patch!
>>
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -11916,6 +11916,8 @@ L: [email protected]
>> > S: Odd Fixes
>> > F: arch/powerpc/platforms/powermac/
>> > F: drivers/macintosh/
>> > +X: drivers/macintosh/adb-iop.c
>> > +X: drivers/macintosh/via-macii.c
>> >
>> > LINUX FOR POWERPC (32-BIT AND 64-BIT)
>> > M: Michael Ellerman <[email protected]>
>>
>> LGTM, as there are already entries for these two files under
>> "M68K ON APPLE MACINTOSH".
>
> Right. I should have addded those "X files" in commit 2ae92e8b9b7.
Or I should have suggested it when I acked that commit :}
cheers
On Wed, 31 May 2023 22:50:23 +1000, Michael Ellerman wrote:
> The powerpc section has a "F:" entry for drivers/macintosh, matching all
> files in or below drivers/macintosh. That is correct for the most part,
> but there are a couple of m68k-only drivers in the directory, so exclude
> those.
>
>
Applied to powerpc/next.
[1/1] MAINTAINERS: Exclude m68k-only drivers from powerpc entry
https://git.kernel.org/powerpc/c/a43d52ab96f97967f4c5d28d1607fb1179057786
cheers