2020-03-22 14:18:41

by Alain Volmat

Subject: [PATCH] clk: clk-flexgen: fix clock-critical handling

Fixes an issue leading to having all clocks following a critical
clocks marked as well as criticals.

Fixes: fa6415affe20 ("clk: st: clk-flexgen: Detect critical clocks")

Signed-off-by: Alain Volmat <[email protected]>
---
drivers/clk/st/clk-flexgen.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
index 4413b6e04a8e..55873d4b7603 100644
--- a/drivers/clk/st/clk-flexgen.c
+++ b/drivers/clk/st/clk-flexgen.c
@@ -375,6 +375,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)
break;
}

+ flex_flags &= ~CLK_IS_CRITICAL;
of_clk_detect_critical(np, i, &flex_flags);

/*
--
2.17.1

2020-03-23 09:21:15

by Patrice CHOTARD

Subject: Re: [PATCH] clk: clk-flexgen: fix clock-critical handling

Hi Alain

On 3/22/20 3:07 PM, Alain Volmat wrote:
> Fixes an issue leading to having all clocks following a critical
> clocks marked as well as criticals.
>
> Fixes: fa6415affe20 ("clk: st: clk-flexgen: Detect critical clocks")
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> drivers/clk/st/clk-flexgen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/st/clk-flexgen.c b/drivers/clk/st/clk-flexgen.c
> index 4413b6e04a8e..55873d4b7603 100644
> --- a/drivers/clk/st/clk-flexgen.c
> +++ b/drivers/clk/st/clk-flexgen.c
> @@ -375,6 +375,7 @@ static void __init st_of_flexgen_setup(struct device_node *np)
> break;
> }
>
> + flex_flags &= ~CLK_IS_CRITICAL;
> of_clk_detect_critical(np, i, &flex_flags);
>
> /*


Reviewed-by: Patrice Chotard <[email protected]>

Thanks

Patrice

2020-05-27 10:39:40

by Stephen Boyd

Subject: Re: [PATCH] clk: clk-flexgen: fix clock-critical handling

Quoting Alain Volmat (2020-03-22 07:07:40)
> Fixes an issue leading to having all clocks following a critical
> clocks marked as well as criticals.
>
> Fixes: fa6415affe20 ("clk: st: clk-flexgen: Detect critical clocks")
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---

Applied to clk-next