2024-05-15 15:04:46

by Julien Panis

[permalink] [raw]
Subject: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188

Filtered mode is not supported on mt8188 SoC and is the source of bad
results. Move to immediate mode which provides good temperatures.

Signed-off-by: Julien Panis <[email protected]>
---
Filtered mode was set by mistake and difficulties with the test setup
prevented from catching this earlier. Use default mode (immediate mode)
instead.
---
drivers/thermal/mediatek/lvts_thermal.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
index 0bb3a495b56e..82c355c466cf 100644
--- a/drivers/thermal/mediatek/lvts_thermal.c
+++ b/drivers/thermal/mediatek/lvts_thermal.c
@@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 1),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};

@@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(0, 1, 0, 0),
.offset = 0x0,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 1, 0),
.offset = 0x100,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x200,
- .mode = LVTS_MSR_FILTERED_MODE,
},
{
.lvts_sensor = {
@@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
},
VALID_SENSOR_MAP(1, 1, 0, 0),
.offset = 0x300,
- .mode = LVTS_MSR_FILTERED_MODE,
}
};


---
base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1

Best regards,
--
Julien Panis <[email protected]>



2024-05-15 15:23:07

by Nicolas Pitre

[permalink] [raw]
Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188

On Wed, 15 May 2024, Julien Panis wrote:

> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Signed-off-by: Julien Panis <[email protected]>

Reviewed-by: Nicolas Pitre <[email protected]>


> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..82c355c466cf 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 1),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
> @@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(0, 1, 0, 0),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x200,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x300,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
>
> ---
> base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
> change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
>
> Best regards,
> --
> Julien Panis <[email protected]>
>
>

Subject: Re: [PATCH] thermal/drivers/mediatek/lvts_thermal: Remove filtered mode for mt8188

Il 15/05/24 17:03, Julien Panis ha scritto:
> Filtered mode is not supported on mt8188 SoC and is the source of bad
> results. Move to immediate mode which provides good temperatures.
>
> Signed-off-by: Julien Panis <[email protected]>

Please add the relevant Fixes tag, after which:

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

> ---
> Filtered mode was set by mistake and difficulties with the test setup
> prevented from catching this earlier. Use default mode (immediate mode)
> instead.
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 0bb3a495b56e..82c355c466cf 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -1458,7 +1458,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 1),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1469,7 +1468,6 @@ static const struct lvts_ctrl_data mt8188_lvts_mcu_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
> @@ -1483,7 +1481,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(0, 1, 0, 0),
> .offset = 0x0,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1496,7 +1493,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 1, 0),
> .offset = 0x100,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1507,7 +1503,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x200,
> - .mode = LVTS_MSR_FILTERED_MODE,
> },
> {
> .lvts_sensor = {
> @@ -1518,7 +1513,6 @@ static const struct lvts_ctrl_data mt8188_lvts_ap_data_ctrl[] = {
> },
> VALID_SENSOR_MAP(1, 1, 0, 0),
> .offset = 0x300,
> - .mode = LVTS_MSR_FILTERED_MODE,
> }
> };
>
>
> ---
> base-commit: 82d92a9a1b9ea0ea52aff27cddd05009b4edad49
> change-id: 20240515-mtk-thermal-mt8188-mode-fix-e583d9a31da1
>
> Best regards,