The SPI_ALTERA_CORE config symbol controls compilation of the Altera SPI
Controller core code. It is already selected by all of its users, so
there is no reason to make it visible, unless compile-testing.
Fixes: b0c3d9354de1f87e ("spi: altera: separate core code from platform code")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/spi/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 7f03d1e50361ea94..17a55214e66ad928 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -65,7 +65,7 @@ config SPI_ALTERA
This is the driver for the Altera SPI Controller.
config SPI_ALTERA_CORE
- tristate "Altera SPI Controller core code"
+ tristate "Altera SPI Controller core code" if COMPILE_TEST
select REGMAP
help
"The core code for the Altera SPI Controller"
--
2.25.1
Hi Geert,
Thanks for the fix!
Matthew
Acked-by: Matthew Gerlach <[email protected]>
On Tue, 27 Apr 2021, Geert Uytterhoeven wrote:
> The SPI_ALTERA_CORE config symbol controls compilation of the Altera SPI
> Controller core code. It is already selected by all of its users, so
> there is no reason to make it visible, unless compile-testing.
>
> Fixes: b0c3d9354de1f87e ("spi: altera: separate core code from platform code")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/spi/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 7f03d1e50361ea94..17a55214e66ad928 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -65,7 +65,7 @@ config SPI_ALTERA
> This is the driver for the Altera SPI Controller.
>
> config SPI_ALTERA_CORE
> - tristate "Altera SPI Controller core code"
> + tristate "Altera SPI Controller core code" if COMPILE_TEST
> select REGMAP
> help
> "The core code for the Altera SPI Controller"
> --
> 2.25.1
>
>
On Tue, 27 Apr 2021 16:38:42 +0200, Geert Uytterhoeven wrote:
> The SPI_ALTERA_CORE config symbol controls compilation of the Altera SPI
> Controller core code. It is already selected by all of its users, so
> there is no reason to make it visible, unless compile-testing.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: altera: Make SPI_ALTERA_CORE invisible
commit: 41f48a29ebd5ce944e412f491f1876b5abeff1d6
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark