2023-10-12 08:41:44

by Moudy Ho (何宗原)

[permalink] [raw]
Subject: [PATCH v7 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

Added the configuration for MT8195 RDMA. In comparison to MT8183, it
no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox.

Signed-off-by: Moudy Ho <[email protected]>
---
.../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
index c043204cf210..504334a76fb3 100644
--- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
+++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
@@ -22,6 +22,7 @@ properties:
compatible:
enum:
- mediatek,mt8183-mdp3-rdma
+ - mediatek,mt8195-mdp3-rdma
- mediatek,mt8195-vdo1-rdma

reg:
@@ -58,7 +59,7 @@ properties:

mboxes:
minItems: 1
- maxItems: 2
+ maxItems: 5

interrupts:
maxItems: 1
@@ -98,6 +99,29 @@ allOf:
- mboxes
- mediatek,gce-events

+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8195-mdp3-rdma
+
+ then:
+ properties:
+ clocks:
+ items:
+ - description: RDMA clock
+
+ mboxes:
+ items:
+ - description: used for 1st data pipe from RDMA
+ - description: used for 2nd data pipe from RDMA
+ - description: used for 3rd data pipe from RDMA
+ - description: used for 4th data pipe from RDMA
+ - description: used for the data pipe from SPLIT
+
+ required:
+ - mediatek,gce-events
+
- if:
properties:
compatible:
--
2.18.0


Subject: Re: [PATCH v7 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

Il 12/10/23 10:40, Moudy Ho ha scritto:
> Added the configuration for MT8195 RDMA. In comparison to MT8183, it
> no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox.
>
> Signed-off-by: Moudy Ho <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-10-13 06:47:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v7 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA

On 12/10/2023 10:40, Moudy Ho wrote:
> Added the configuration for MT8195 RDMA. In comparison to MT8183, it
> no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox.
>
> Signed-off-by: Moudy Ho <[email protected]>
> ---
> .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> index c043204cf210..504334a76fb3 100644
> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml
> @@ -22,6 +22,7 @@ properties:
> compatible:
> enum:
> - mediatek,mt8183-mdp3-rdma
> + - mediatek,mt8195-mdp3-rdma
> - mediatek,mt8195-vdo1-rdma
>
> reg:
> @@ -58,7 +59,7 @@ properties:
>
> mboxes:
> minItems: 1
> - maxItems: 2
> + maxItems: 5
>
> interrupts:
> maxItems: 1
> @@ -98,6 +99,29 @@ allOf:
> - mboxes
> - mediatek,gce-events
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: mediatek,mt8195-mdp3-rdma
> +
> + then:
> + properties:
> + clocks:
> + items:
> + - description: RDMA clock
> +
> + mboxes:
> + items:
> + - description: used for 1st data pipe from RDMA
> + - description: used for 2nd data pipe from RDMA
> + - description: used for 3rd data pipe from RDMA
> + - description: used for 4th data pipe from RDMA
> + - description: used for the data pipe from SPLIT

Missing interrupts

Best regards,
Krzysztof