2008-01-31 04:41:50

by Kumar Gala

[permalink] [raw]
Subject: SPI related Kconfig warning

Was wondering if anyone was looking at the cause of this warning in
top of linus's tree (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0)

drivers/spi/Kconfig:156:warning: 'select' used by config symbol
'SPI_PXA2XX' refers to undefined symbol 'PXA_SSP'

I was doing a build of a ppc kernel.

- k


2008-01-31 07:22:08

by David Brownell

[permalink] [raw]
Subject: Re: [spi-devel-general] SPI related Kconfig warning

On Wednesday 30 January 2008, Kumar Gala wrote:
> Was wondering if anyone was looking at the cause of this warning in
> top of linus's tree (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0)
>
> drivers/spi/Kconfig:156:warning: 'select' used by config symbol
> 'SPI_PXA2XX' refers to undefined symbol 'PXA_SSP'
>
> I was doing a build of a ppc kernel.

Happens on x86, AVR32, and non-PXA ARM too. Came from some PXA cleanup
patches. Eric, didn't you have a patch for this?

(Of course I *still* don't understand why kconfig bothers to look
at reverse dependencies whose "forward" ones can never be satisfied.
If it stopped looking at those, lots of similar problems would vanish.)

- Dave

2008-01-31 09:27:21

by Eric Miao

[permalink] [raw]
Subject: Re: [spi-devel-general] SPI related Kconfig warning

On Jan 31, 2008 3:21 PM, David Brownell <[email protected]> wrote:
> On Wednesday 30 January 2008, Kumar Gala wrote:
> > Was wondering if anyone was looking at the cause of this warning in
> > top of linus's tree (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0)
> >
> > drivers/spi/Kconfig:156:warning: 'select' used by config symbol
> > 'SPI_PXA2XX' refers to undefined symbol 'PXA_SSP'
> >
> > I was doing a build of a ppc kernel.
>
> Happens on x86, AVR32, and non-PXA ARM too. Came from some PXA cleanup
> patches. Eric, didn't you have a patch for this?
>

Nope.

If moving the symbol PXA_SSP to the "depends on" list, this option will
remain invisible if a careless user does not select PXA_SSP.

Yet I'm not sure this is the way to go or mandatory by the kconfig rules.

> (Of course I *still* don't understand why kconfig bothers to look
> at reverse dependencies whose "forward" ones can never be satisfied.
> If it stopped looking at those, lots of similar problems would vanish.)
>
> - Dave
>



--
Cheers
- eric

2008-02-02 20:51:56

by Sam Ravnborg

[permalink] [raw]
Subject: Re: SPI related Kconfig warning

On Wed, Jan 30, 2008 at 10:41:33PM -0600, Kumar Gala wrote:
> Was wondering if anyone was looking at the cause of this warning in
> top of linus's tree (8af03e782cae1e0a0f530ddd22301cdd12cf9dc0)
>
> drivers/spi/Kconfig:156:warning: 'select' used by config symbol
> 'SPI_PXA2XX' refers to undefined symbol 'PXA_SSP'
>
> I was doing a build of a ppc kernel.

I have now killed that warning. from kconfig. It has
proved rather useless but annoying.

Sam