2008-11-24 16:43:31

by Mike Rapoport

Subject: [PATCH] regulator: da903x: add '\n' to error messages

Signed-off-by: Mike Rapoport <[email protected]>
---
drivers/regulator/da903x.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
index 773b29c..83101d6 100644
--- a/drivers/regulator/da903x.c
+++ b/drivers/regulator/da903x.c
@@ -102,7 +102,7 @@ static int da903x_set_ldo_voltage(struct regulator_dev *rdev,
uint8_t val, mask;

if (check_range(info, min_uV, max_uV)) {
- pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+ pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
return -EINVAL;
}

@@ -172,7 +172,7 @@ static int da9030_set_ldo1_15_voltage(struct regulator_dev *rdev,
int ret;

if (check_range(info, min_uV, max_uV)) {
- pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+ pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
return -EINVAL;
}

@@ -199,7 +199,7 @@ static int da9030_set_ldo14_voltage(struct regulator_dev *rdev,
int thresh;

if (check_range(info, min_uV, max_uV)) {
- pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+ pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
return -EINVAL;
}

@@ -248,7 +248,7 @@ static int da9034_set_dvc_voltage(struct regulator_dev *rdev,
int ret;

if (check_range(info, min_uV, max_uV)) {
- pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+ pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
return -EINVAL;
}

@@ -273,7 +273,7 @@ static int da9034_set_ldo12_voltage(struct regulator_dev *rdev,
uint8_t val, mask;

if (check_range(info, min_uV, max_uV)) {
- pr_err("invalid voltage range (%d, %d) uV", min_uV, max_uV);
+ pr_err("invalid voltage range (%d, %d) uV\n", min_uV, max_uV);
return -EINVAL;
}

--
1.5.6.4

2008-11-25 06:55:46

by Eric Miao

Subject: Re: [PATCH] regulator: da903x: add '\n' to error messages

On Tue, Nov 25, 2008 at 12:43 AM, Mike Rapoport <[email protected]> wrote:
>
> Signed-off-by: Mike Rapoport <[email protected]>

Acked-by: Eric Miao <[email protected]>

2008-11-25 11:36:18

by Liam Girdwood

Subject: Re: [PATCH] regulator: da903x: add '\n' to error messages

On Mon, 2008-11-24 at 18:43 +0200, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> drivers/regulator/da903x.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)

Applied.

Thanks

Liam