2008-12-15 10:28:22

by Jean Delvare

[permalink] [raw]
Subject: [PATCH] da903x: Fix section mismatch

da903x_remove_subdevs() can be called in case of device initialization
error, so it shouldn't be tagged __devexit.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Mike Rapoport <[email protected]>
Cc: Eric Miao <[email protected]>
Cc: Samuel Ortiz <[email protected]>
Cc: Liam Girdwood <[email protected]>
---
drivers/mfd/da903x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.28-rc8.orig/drivers/mfd/da903x.c 2008-11-21 10:59:44.000000000 +0100
+++ linux-2.6.28-rc8/drivers/mfd/da903x.c 2008-12-15 11:19:30.000000000 +0100
@@ -435,13 +435,13 @@ static const struct i2c_device_id da903x
};
MODULE_DEVICE_TABLE(i2c, da903x_id_table);

-static int __devexit __remove_subdev(struct device *dev, void *unused)
+static int __remove_subdev(struct device *dev, void *unused)
{
platform_device_unregister(to_platform_device(dev));
return 0;
}

-static int __devexit da903x_remove_subdevs(struct da903x_chip *chip)
+static int da903x_remove_subdevs(struct da903x_chip *chip)
{
return device_for_each_child(chip->dev, NULL, __remove_subdev);
}


--
Jean Delvare


2008-12-15 10:45:49

by Eric Miao

[permalink] [raw]
Subject: Re: [PATCH] da903x: Fix section mismatch

On Mon, Dec 15, 2008 at 6:28 PM, Jean Delvare <[email protected]> wrote:
> da903x_remove_subdevs() can be called in case of device initialization
> error, so it shouldn't be tagged __devexit.
>

Good catch.

Acked-by: Eric Miao <[email protected]>