2024-04-01 13:18:26

by Christophe JAILLET

Subject: [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data

In "struct st_ahci_drv_data", the 'ahci' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Apparently, it has never be used. It is not a left-over from a refactoring.

Compile tested only.
---
drivers/ata/ahci_st.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ata/ahci_st.c b/drivers/ata/ahci_st.c
index d4a626f87963..79a8b0aa37bf 100644
--- a/drivers/ata/ahci_st.c
+++ b/drivers/ata/ahci_st.c
@@ -30,7 +30,6 @@
#define ST_AHCI_OOBR_CIMAX_SHIFT 0

struct st_ahci_drv_data {
- struct platform_device *ahci;
struct reset_control *pwr;
struct reset_control *sw_rst;
struct reset_control *pwr_rst;
--
2.44.0

2024-04-02 03:29:34

by Damien Le Moal

Subject: Re: [PATCH] ata: ahci_st: Remove an unused field in struct st_ahci_drv_data

On 4/1/24 21:44, Christophe JAILLET wrote:
> In "struct st_ahci_drv_data", the 'ahci' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Applied to for-6.9-fixes. Thanks !

--
Damien Le Moal
Western Digital Research