2008-10-18 01:15:48

by Fred .Flintstone

[permalink] [raw]
Subject: Stop accept/merge code that does not compile without warnings

I read that Linus merged the GEM code.
He said about it that it was untested crap code that didn't compile
cleanly, it spitted out compiler warnings, and the code was ugly,
buggy and bad.

Kernel development is supposed to be done by professionals.
Please stop merge code that does not compile without warnings.
If when you compile it, if it does spit out warnings, then reject it!

We need professional quality, we cant merge any crap, else we get
unstable kernel with lots of bugs.
Kernel developers are supposed to be expert programmers, they
shouldn't have code that spits out warnings.


2008-10-18 09:54:49

by Pekka Enberg

[permalink] [raw]
Subject: Re: Stop accept/merge code that does not compile without warnings

Hi Fred,

On Sat, Oct 18, 2008 at 4:15 AM, Fred . <[email protected]> wrote:
> Kernel development is supposed to be done by professionals.
> Please stop merge code that does not compile without warnings.
> If when you compile it, if it does spit out warnings, then reject it!
>
> We need professional quality, we cant merge any crap, else we get
> unstable kernel with lots of bugs.
> Kernel developers are supposed to be expert programmers, they
> shouldn't have code that spits out warnings.

Thanks for the excellent advice! I'm sure we'll all be more careful in
the future knowing you're looking after us.

Keep up the good work.

Pekka