2017-11-02 01:28:28

by David Daney

[permalink] [raw]
Subject: Re: [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

On 11/01/2017 06:09 PM, Florian Fainelli wrote:
> On 11/01/2017 05:36 PM, David Daney wrote:
>> From: Carlos Munoz <[email protected]>
>>
>> Add bindings for Common Ethernet Interface (BGX) block.
>>
>> Signed-off-by: Carlos Munoz <[email protected]>
>> Signed-off-by: Steven J. Hill <[email protected]>
>> Signed-off-by: David Daney <[email protected]>
>> ---
> [snip]
>> +Properties:
>> +
>> +- compatible: "cavium,octeon-7360-xcv": Compatibility with cn73xx SOCs.
>> +
>> +- reg: The index of the interface within the BGX block.
>> +
>> +- local-mac-address: Mac address for the interface.
>> +
>> +- phy-handle: phandle to the phy node connected to the interface.
>> +
>> +- cavium,rx-clk-delay-bypass: Set to <1> to bypass the rx clock delay setting.
>> + Needed by the Micrel PHY.
>
> Is not that implied by an appropriate "phy-mode" property already?

I think you are correct. That string never appears in the source code,
so I am going to remove that property from the binding document for the
next revision of the patch set.

Thanks,
David Daney

From 1582914610184738802@xxx Thu Nov 02 01:10:08 +0000 2017
X-GM-THRID: 1582912745835708465
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread