2019-04-01 05:08:49

by Anson Huang

Subject: [PATCH] pinctrl: freescale: use devm_platform_ioremap_resource() to simplify code

Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.

Signed-off-by: Anson Huang <[email protected]>
---
drivers/pinctrl/freescale/pinctrl-imx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
index 188001b..cc6f5cc 100644
--- a/drivers/pinctrl/freescale/pinctrl-imx.c
+++ b/drivers/pinctrl/freescale/pinctrl-imx.c
@@ -785,7 +785,6 @@ int imx_pinctrl_probe(struct platform_device *pdev,
struct pinctrl_desc *imx_pinctrl_desc;
struct device_node *np;
struct imx_pinctrl *ipctl;
- struct resource *res;
struct regmap *gpr;
int ret, i;

@@ -817,8 +816,7 @@ int imx_pinctrl_probe(struct platform_device *pdev,
ipctl->pin_regs[i].conf_reg = -1;
}

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ipctl->base = devm_ioremap_resource(&pdev->dev, res);
+ ipctl->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ipctl->base))
return PTR_ERR(ipctl->base);

--
2.7.4

2019-04-01 08:13:11

by Mukesh Ojha

Subject: Re: [PATCH] pinctrl: freescale: use devm_platform_ioremap_resource() to simplify code

On 4/1/2019 10:37 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> drivers/pinctrl/freescale/pinctrl-imx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c
> index 188001b..cc6f5cc 100644
> --- a/drivers/pinctrl/freescale/pinctrl-imx.c
> +++ b/drivers/pinctrl/freescale/pinctrl-imx.c
> @@ -785,7 +785,6 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> struct pinctrl_desc *imx_pinctrl_desc;
> struct device_node *np;
> struct imx_pinctrl *ipctl;
> - struct resource *res;
> struct regmap *gpr;
> int ret, i;
>
> @@ -817,8 +816,7 @@ int imx_pinctrl_probe(struct platform_device *pdev,
> ipctl->pin_regs[i].conf_reg = -1;
> }
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ipctl->base = devm_ioremap_resource(&pdev->dev, res);
> + ipctl->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ipctl->base))
> return PTR_ERR(ipctl->base);
>

2019-04-08 11:43:02

by Linus Walleij

Subject: Re: [PATCH] pinctrl: freescale: use devm_platform_ioremap_resource() to simplify code

On Mon, Apr 1, 2019 at 7:07 AM Anson Huang <[email protected]> wrote:

> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <[email protected]>

Patch applied.

Yours,
Linus Walleij