2017-11-29 18:14:22

by Jarkko Nikula

[permalink] [raw]
Subject: Re: [PATCH] x86/entry/64: Fix native_load_gs_index() SWAPGS handling with IRQ state tracing enabled

On 11/29/2017 11:28 AM, Thomas Gleixner wrote:
> On Wed, 29 Nov 2017, Jarkko Nikula wrote:
>
>> On 11/29/2017 09:09 AM, Ingo Molnar wrote:
>>> Hm, that commit looks broken with irq-tracing enabled. Does the
>>> patch below fix it?
>>>
>> No, it makes the machine not to boot at all :-(
>>
>> Log below when I used my config (now attached). With x86_64_defconfig it
>> booted twice but didn't survive suspend/resume. However several other boot
>> attempts with x86_64_defconfig failed somewhat similarly. Not in the same
>> place but hanging anyway. With my own config it seems to always end up failing
>> in trace_hardirqs_off_caller.
>
> Does it work when you disable all the tracing muck?
>
My config seems to work with Ingo's patch if I disable both
CONFIG_FTRACE and CONFIG_PROVE_LOCKING which disables the
CONFIG_TRACE_IRQS_FLAGS.

x86_64_defconfig with CONFIG_FTRACE disabled is still unstable.
Sometimes hangs during bootup and sometimes boots up to userspace.

--
Jarkko

From 1585424303567257150@xxx Wed Nov 29 18:00:38 +0000 2017
X-GM-THRID: 1585383480543829622
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread