2021-09-03 12:37:20

by Jens Axboe

[permalink] [raw]
Subject: Re: [PATCH v6] libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.

On 9/3/21 3:44 AM, Kate Hsuan wrote:
> Many users are reporting that the Samsung 860 and 870 SSD are having
> various issues when combined with AMD/ATI (vendor ID 0x1002) SATA
> controllers and only completely disabling NCQ helps to avoid these
> issues.
>
> Always disabling NCQ for Samsung 860/870 SSDs regardless of the host
> SATA adapter vendor will cause I/O performance degradation with well
> behaved adapters. To limit the performance impact to ATI adapters,
> introduce the ATA_HORKAGE_NO_NCQ_ON_ATI flag to force disable NCQ
> only for these adapters.
>
> Also, two libata.force parameters (noncqati and ncqati) are introduced
> to disable and enable the NCQ for the system which equipped with ATI
> SATA adapter and Samsung 860 and 870 SSDs. The user can determine NCQ
> function to be enabled or disabled according to the demand.
>
> After verifying the chipset from the user reports, the issue appears
> on AMD/ATI SB7x0/SB8x0/SB9x0 SATA Controllers and does not appear on
> recent AMD SATA adapters. The vendor ID of ATI should be 0x1002.
> Therefore, ATA_HORKAGE_NO_NCQ_ON_AMD was modified to
> ATA_HORKAGE_NO_NCQ_ON_ATI.

What's this patch against?

--
Jens Axboe


2021-09-03 14:43:33

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH v6] libata: Add ATA_HORKAGE_NO_NCQ_ON_ATI for Samsung 860 and 870 SSD.

Hi,

On 9/3/21 2:35 PM, Jens Axboe wrote:
> On 9/3/21 3:44 AM, Kate Hsuan wrote:
>> Many users are reporting that the Samsung 860 and 870 SSD are having
>> various issues when combined with AMD/ATI (vendor ID 0x1002) SATA
>> controllers and only completely disabling NCQ helps to avoid these
>> issues.
>>
>> Always disabling NCQ for Samsung 860/870 SSDs regardless of the host
>> SATA adapter vendor will cause I/O performance degradation with well
>> behaved adapters. To limit the performance impact to ATI adapters,
>> introduce the ATA_HORKAGE_NO_NCQ_ON_ATI flag to force disable NCQ
>> only for these adapters.
>>
>> Also, two libata.force parameters (noncqati and ncqati) are introduced
>> to disable and enable the NCQ for the system which equipped with ATI
>> SATA adapter and Samsung 860 and 870 SSDs. The user can determine NCQ
>> function to be enabled or disabled according to the demand.
>>
>> After verifying the chipset from the user reports, the issue appears
>> on AMD/ATI SB7x0/SB8x0/SB9x0 SATA Controllers and does not appear on
>> recent AMD SATA adapters. The vendor ID of ATI should be 0x1002.
>> Therefore, ATA_HORKAGE_NO_NCQ_ON_AMD was modified to
>> ATA_HORKAGE_NO_NCQ_ON_ATI.
>
> What's this patch against?

linux-block/for-next + my pre-cursor patch from here:

https://lore.kernel.org/linux-ide/[email protected]/T/#u

Regards,

Hans