2017-11-16 04:33:17

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 05/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcsx

The pnp_irq() function returns -1 if an error occurs.
pnp_irq() error checking for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/isdn/hisax/hfc_sx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/isdn/hisax/hfc_sx.c b/drivers/isdn/hisax/hfc_sx.c
index 3aef8e1..99f5a93 100644
--- a/drivers/isdn/hisax/hfc_sx.c
+++ b/drivers/isdn/hisax/hfc_sx.c
@@ -1422,7 +1422,7 @@ int setup_hfcsx(struct IsdnCard *card)
}
card->para[1] = pnp_port_start(pnp_d, 0);
card->para[0] = pnp_irq(pnp_d, 0);
- if (!card->para[0] || !card->para[1]) {
+ if (card->para[0] == -1 || !card->para[1]) {
printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n",
card->para[0], card->para[1]);
pnp_disable_dev(pnp_d);
--
1.9.1


From 1590135130931827401@xxx Sat Jan 20 17:57:13 +0000 2018
X-GM-THRID: 1583900869414443113
X-Gmail-Labels: Inbox,Category Forums,Downloaded_2018-01