2022-02-21 04:55:29

by Yixuan Cao

[permalink] [raw]
Subject: [PATCH 2/2] Documentation/vm/page_owner.rst: fix a phrase

I think that using "by default" will be better.

Signed-off-by: Yixuan Cao <[email protected]>
---
Documentation/vm/page_owner.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
index 2b54e82b9fe1..5ac1c12fcfc2 100644
--- a/Documentation/vm/page_owner.rst
+++ b/Documentation/vm/page_owner.rst
@@ -26,7 +26,7 @@ fragmentation statistics can be obtained through gfp flag information of
each page. It is already implemented and activated if page owner is
enabled. Other usages are more than welcome.

-page owner is disabled in default. So, if you'd like to use it, you need
+page owner is disabled by default. So, if you'd like to use it, you need
to add "page_owner=on" into your boot cmdline. If the kernel is built
with page owner and page owner is disabled in runtime due to no enabling
boot option, runtime overhead is marginal. If disabled in runtime, it
--
2.31.1




2022-02-23 03:30:54

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 2/2] Documentation/vm/page_owner.rst: fix a phrase

On 2/20/22 1:29 AM, Yixuan Cao wrote:
> I think that using "by default" will be better.
>
> Signed-off-by: Yixuan Cao <[email protected]>

While you are at it could you fix others as well:

> ---
> Documentation/vm/page_owner.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/vm/page_owner.rst b/Documentation/vm/page_owner.rst
> index 2b54e82b9fe1..5ac1c12fcfc2 100644
> --- a/Documentation/vm/page_owner.rst
> +++ b/Documentation/vm/page_owner.rst
> @@ -26,7 +26,7 @@ fragmentation statistics can be obtained through gfp flag information of
> each page. It is already implemented and activated if page owner is
> enabled. Other usages are more than welcome.
>
> -page owner is disabled in default. So, if you'd like to use it, you need
> +page owner is disabled by default. So, if you'd like to use it, you need
> to add "page_owner=on" into your boot cmdline. If the kernel is built

page owner is disabled by default. So, if you'd like to use it, you need
to add "page_owner=on" to your boot cmdline.

> with page owner and page owner is disabled in runtime due to no enabling

with page owner and page owner is disabled in runtime due to not enabling

> boot option, runtime overhead is marginal. If disabled in runtime, it
>

With these fixed:

Reviewed-by: Shuah Khan <[email protected]>

thanks,
-- Shuah