2020-12-23 14:14:43

by Zheng Yongjun

Subject: [PATCH -next] md: bcache: use DEFINE_MUTEX (and mutex_init() had been too late)

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/md/bcache/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 46a00134a36a..963d62a15f37 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
};

static struct kobject *bcache_kobj;
-struct mutex bch_register_lock;
+DEFINE_MUTEX(bch_register_lock);
bool bcache_is_reboot;
LIST_HEAD(bch_cache_sets);
static LIST_HEAD(uncached_devices);
@@ -2832,7 +2832,6 @@ static int __init bcache_init(void)

check_module_parameters();

- mutex_init(&bch_register_lock);
init_waitqueue_head(&unregister_wait);
register_reboot_notifier(&reboot);

--
2.22.0

2020-12-23 14:25:08

by Coly Li

Subject: Re: [PATCH -next] md: bcache: use DEFINE_MUTEX (and mutex_init() had been too late)

On 12/23/20 10:12 PM, Zheng Yongjun wrote:
> Signed-off-by: Zheng Yongjun <[email protected]>

NACK. The commit log is necessary to explain why it is too late, IMHO I
don't find the implicit reason from the patch.

Coly Li

> ---
> drivers/md/bcache/super.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index 46a00134a36a..963d62a15f37 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
> };
>
> static struct kobject *bcache_kobj;
> -struct mutex bch_register_lock;
> +DEFINE_MUTEX(bch_register_lock);
> bool bcache_is_reboot;
> LIST_HEAD(bch_cache_sets);
> static LIST_HEAD(uncached_devices);
> @@ -2832,7 +2832,6 @@ static int __init bcache_init(void)
>
> check_module_parameters();
>
> - mutex_init(&bch_register_lock);
> init_waitqueue_head(&unregister_wait);
> register_reboot_notifier(&reboot);
>
>