2018-10-16 09:56:24

by Enric Balletbo i Serra

Subject: [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

This patch avoids that building the bridge/analogix source code with
smatch triggers complaints about inconsistent indenting. It also fixes
a typo in DRM_ERROR message, attch is replaced for attach.

Signed-off-by: Enric Balletbo i Serra <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
---

Changes in v2:
- Fix typo s/attch/attach/
- Add Reviewed-by Laurent Pinchart

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index d68986cea132..3987d5fc9c0d 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1219,12 +1219,12 @@ static int analogix_dp_bridge_attach(struct drm_bridge *bridge)
* plat_data->attch return, that's why we record the connector
* point after plat attached.
*/
- if (dp->plat_data->attach) {
- ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
- if (ret) {
- DRM_ERROR("Failed at platform attch func\n");
- return ret;
- }
+ if (dp->plat_data->attach) {
+ ret = dp->plat_data->attach(dp->plat_data, bridge, connector);
+ if (ret) {
+ DRM_ERROR("Failed at platform attach func\n");
+ return ret;
+ }
}

if (dp->plat_data->panel) {
--
2.19.1

2018-10-29 13:54:00

by Andrzej Hajda

Subject: Re: [PATCH v2] drm/bridge: analogix_dp: Fix misleading indentation reported by smatch

On 16.10.2018 11:53, Enric Balletbo i Serra wrote:
> This patch avoids that building the bridge/analogix source code with
> smatch triggers complaints about inconsistent indenting. It also fixes
> a typo in DRM_ERROR message, attch is replaced for attach.
>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>
> Reviewed-by: Laurent Pinchart <[email protected]>

Queued to drm-misc-next.

Regards
Andrzej