2022-11-03 12:36:26

by Steven Price

Subject: [PATCH] drm/panfrost: Remove type name from internal struct again

Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
native ones") accidentally reverted part of the parent commit
7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
leading to the situation that the Panfrost UAPI header still doesn't
compile correctly in C++.

Revert the accidental revert and pass me a brown paper bag.

Reported-by: Alyssa Rosenzweig <[email protected]>
Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
Signed-off-by: Steven Price <[email protected]>
---
include/uapi/drm/panfrost_drm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
index 6f93c915cc88..9f231d40a146 100644
--- a/include/uapi/drm/panfrost_drm.h
+++ b/include/uapi/drm/panfrost_drm.h
@@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
__u64 nbos;
} reghdr;

- struct pan_bomap_hdr {
+ struct {
__u32 valid;
__u64 iova;
__u32 data[2];
--
2.34.1

2022-11-07 13:46:52

by Alyssa Rosenzweig

Subject: Re: [PATCH] drm/panfrost: Remove type name from internal struct again

Reviewed-by: Alyssa Rosenzweig <[email protected]>

On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
> native ones") accidentally reverted part of the parent commit
> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
> leading to the situation that the Panfrost UAPI header still doesn't
> compile correctly in C++.
>
> Revert the accidental revert and pass me a brown paper bag.
>
> Reported-by: Alyssa Rosenzweig <[email protected]>
> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
> Signed-off-by: Steven Price <[email protected]>
> ---
> include/uapi/drm/panfrost_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
> index 6f93c915cc88..9f231d40a146 100644
> --- a/include/uapi/drm/panfrost_drm.h
> +++ b/include/uapi/drm/panfrost_drm.h
> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
> __u64 nbos;
> } reghdr;
>
> - struct pan_bomap_hdr {
> + struct {
> __u32 valid;
> __u64 iova;
> __u32 data[2];
> --
> 2.34.1
>

2022-11-07 16:21:42

by Steven Price

Subject: Re: [PATCH] drm/panfrost: Remove type name from internal struct again

On 07/11/2022 13:22, Alyssa Rosenzweig wrote:
> Reviewed-by: Alyssa Rosenzweig <[email protected]>

Thanks, pushed to drm-misc-fixes:

c4299907c09a drm/panfrost: Remove type name from internal struct again

Steve

> On Thu, Nov 03, 2022 at 11:40:36AM +0000, Steven Price wrote:
>> Commit 72655fb942c1 ("drm/panfrost: replace endian-specific types with
>> native ones") accidentally reverted part of the parent commit
>> 7228d9d79248 ("drm/panfrost: Remove type name from internal structs")
>> leading to the situation that the Panfrost UAPI header still doesn't
>> compile correctly in C++.
>>
>> Revert the accidental revert and pass me a brown paper bag.
>>
>> Reported-by: Alyssa Rosenzweig <[email protected]>
>> Fixes: 72655fb942c1 ("drm/panfrost: replace endian-specific types with native ones")
>> Signed-off-by: Steven Price <[email protected]>
>> ---
>> include/uapi/drm/panfrost_drm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/uapi/drm/panfrost_drm.h b/include/uapi/drm/panfrost_drm.h
>> index 6f93c915cc88..9f231d40a146 100644
>> --- a/include/uapi/drm/panfrost_drm.h
>> +++ b/include/uapi/drm/panfrost_drm.h
>> @@ -254,7 +254,7 @@ struct panfrost_dump_object_header {
>> __u64 nbos;
>> } reghdr;
>>
>> - struct pan_bomap_hdr {
>> + struct {
>> __u32 valid;
>> __u64 iova;
>> __u32 data[2];
>> --
>> 2.34.1
>>