On 11/11/2023 01:49, David Dai wrote:
> Adding bindings to represent a virtual cpufreq device.
>
> Virtual machines may expose MMIO regions for a virtual cpufreq device
> for guests to read frequency information or to request frequency
> selection. The virtual cpufreq device has an individual controller for
> each frequency domain.
>
> Co-developed-by: Saravana Kannan <[email protected]>
> Signed-off-by: Saravana Kannan <[email protected]>
> Signed-off-by: David Dai <[email protected]>
> ---
> .../cpufreq/qemu,cpufreq-virtual.yaml | 99 +++++++++++++++++++
> 1 file changed, 99 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml
>
> diff --git a/Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml b/Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml
> new file mode 100644
> index 000000000000..16606cf1fd1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/qemu,cpufreq-virtual.yaml
> @@ -0,0 +1,99 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/cpufreq/qemu,cpufreq-virtual.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Virtual CPUFreq
> +
> +maintainers:
> + - David Dai <[email protected]>
> + - Saravana Kannan <[email protected]>
> +
> +description:
> + Virtual CPUFreq is a virtualized driver in guest kernels that sends frequency
> + selection of its vCPUs as a hint to the host through MMIO regions. Each vCPU
> + is associated with a frequency domain which can be shared with other vCPUs.
> + Each frequency domain has its own set of registers for frequency controls.
> +
> +properties:
> + compatible:
> + const: qemu,virtual-cpufreq
> +
> + reg:
> + maxItems: 1
> + description:
> + Address and size of region containing frequency controls for each of the
> + frequency domains. Regions for each frequency domain is placed
> + contiugously and contain registers for controlling DVFS(Dynamic Frequency
> + and Voltage) characteristics. The size of the region is proportional to
> + total number of frequency domains.
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + // This example shows a two CPU configuration with a frequency domain
> + // for each CPU.
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu@0 {
> + compatible = "arm,armv8";
> + device_type = "cpu";
> + reg = <0x0>;
> + operating-points-v2 = <&opp_table0>;
> + };
> +
> + cpu@1 {
> + compatible = "arm,armv8";
> + device_type = "cpu";
> + reg = <0x0>;
> + operating-points-v2 = <&opp_table1>;
> + };
> + };
> +
> + opp_table0: opp-table-0 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp1098000000 {
> + opp-hz = /bits/ 64 <1098000000>;
> + opp-level = <1>;
> + };
> +
> + opp1197000000 {
> + opp-hz = /bits/ 64 <1197000000>;
> + opp-level = <2>;
> + };
> + };
> +
> + opp_table1: opp-table-1 {
> + compatible = "operating-points-v2";
> + opp-shared;
> +
> + opp1106000000 {
> + opp-hz = /bits/ 64 <1106000000>;
> + opp-level = <1>;
> + };
> +
> + opp1277000000 {
> + opp-hz = /bits/ 64 <1277000000>;
> + opp-level = <2>;
> + };
> + };
NIT: If my understanding is correct, it might be worth re-iterating that
these OPPs should mirror the host frequency domain this vCPU is pinned to.
Also, since VM migration has been mentioned elsewhere in this thread, am
I right in saying that you can't change these OPPs after registration?
So, even if one wants to migrate, one has to migrate to an SoC with the
same frequency domains anyway, otherwise the OPPs in the VM are entirely
bogus?
> +
> + soc {
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + cpufreq@1040000 {
> + compatible = "qemu,virtual-cpufreq";
> + reg = <0x1040000 0x10>;
> + };
> + };