2023-07-31 06:34:35

by Thomas Weißschuh

Subject: Re: [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Hi Yuan!

On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> Thanks to your advice and I really learned a lot from it.
>
> V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in test
> case.

Thanks!

I have some more comments for the patches.

For new revisions you should also link to the old revision.

> Best regards,
> Yuan Tan
>
> Yuan Tan (2):
> tools/nolibc: add pipe() and pipe2() support
> selftests/nolibc: add testcase for pipe
>
> tools/include/nolibc/sys.h | 24 ++++++++++++++
> tools/testing/selftests/nolibc/nolibc-test.c | 35 ++++++++++++++++++++
> 2 files changed, 59 insertions(+)
>
> --
> 2.34.1
>

2023-07-31 11:35:41

by Yuan Tan

Subject: Re: [PATCH v2 0/2] tools/nolibc: add pipe(), pipe2() and their testcase

Hi Thomas,

On Mon, 2023-07-31 at 08:13 +0200, Thomas Weißschuh wrote:
> Hi Yuan!
>
> On 2023-07-31 13:50:31+0800, Yuan Tan wrote:
> > Thanks to your advice and I really learned a lot from it.
> >
> > V2 now uses pipe2() to wrap pipe(), and fixes the strcmp issue in
> > test
> > case.
>
> Thanks!
>
> I have some more comments for the patches.
>
> For new revisions you should also link to the old revision.
>

I sincerely appreciate your valuable advice. As a newcomer, I will
certainly take note of it next time. :)

> > Best regards,
> > Yuan Tan
> >
> > Yuan Tan (2):
> >   tools/nolibc: add pipe() and pipe2() support
> >   selftests/nolibc: add testcase for pipe
> >
> >  tools/include/nolibc/sys.h                   | 24 ++++++++++++++
> >  tools/testing/selftests/nolibc/nolibc-test.c | 35
> > ++++++++++++++++++++
> >  2 files changed, 59 insertions(+)
> >
> > --
> > 2.34.1
> >
>