2021-07-30 19:11:02

by Jaegeuk Kim

Subject: [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

We need to get sbi->s_flag to understand the current f2fs status as well.
One example is SBI_NEED_FSCK.

Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/debug.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index 53ed1e9191f0..473ad04d1891 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -333,11 +333,12 @@ static int stat_show(struct seq_file *s, void *v)
list_for_each_entry(si, &f2fs_stat_list, stat_list) {
update_general_status(si->sbi);

- seq_printf(s, "\n=====[ partition info(%pg). #%d, %s, CP: %s]=====\n",
+ seq_printf(s, "\n=====[ partition info(%pg). #%d, %s, CP: %s (sbi: 0x%lx)]=====\n",
si->sbi->sb->s_bdev, i++,
f2fs_readonly(si->sbi->sb) ? "RO": "RW",
is_set_ckpt_flags(si->sbi, CP_DISABLED_FLAG) ?
- "Disabled": (f2fs_cp_error(si->sbi) ? "Error": "Good"));
+ "Disabled": (f2fs_cp_error(si->sbi) ? "Error": "Good"),
+ si->sbi->s_flag);
seq_printf(s, "[SB: 1] [CP: 2] [SIT: %d] [NAT: %d] ",
si->sit_area_segs, si->nat_area_segs);
seq_printf(s, "[SSA: %d] [MAIN: %d",
--
2.32.0.554.ge1b32706d8-goog

2021-07-30 23:46:26

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

On 2021/7/31 3:09, Jaegeuk Kim wrote:
> We need to get sbi->s_flag to understand the current f2fs status as well.
> One example is SBI_NEED_FSCK.

Typo in patch title: "f2f/sstatus".

Please note that there is a sysfs entry /sys/fs/f2fs/<devname/stat/sb_status.

>
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2021-07-31 00:48:20

by Jaegeuk Kim

Subject: Re: [f2fs-dev] [PATCH] f2fs: show sbi status in debugfs/f2f/sstatus

On 07/31, Chao Yu wrote:
> On 2021/7/31 3:09, Jaegeuk Kim wrote:
> > We need to get sbi->s_flag to understand the current f2fs status as well.
> > One example is SBI_NEED_FSCK.
>
> Typo in patch title: "f2f/sstatus".
>
> Please note that there is a sysfs entry /sys/fs/f2fs/<devname/stat/sb_status.

Sure. Thanks.

>
> >
> > Signed-off-by: Jaegeuk Kim <[email protected]>
>
> Reviewed-by: Chao Yu <[email protected]>
>
> Thanks,