2024-06-03 00:05:47

by Jeff Johnson

Subject: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/block/floppy.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 25c9d85667f1..854a88cf56bd 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
module_param(FLOPPY_IRQ, int, 0);
module_param(FLOPPY_DMA, int, 0);
MODULE_AUTHOR("Alain L. Knaff");
+MODULE_DESCRIPTION("Normal floppy disk support");
MODULE_LICENSE("GPL");

/* This doesn't actually get used other than for module information */

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-floppy-1984117350ec

2024-06-03 10:36:05

by Denis Efremov (Oracle)

Subject: Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro

On 6/3/24 04:05, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>
> ---
> drivers/block/floppy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 25c9d85667f1..854a88cf56bd 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
> module_param(FLOPPY_IRQ, int, 0);
> module_param(FLOPPY_DMA, int, 0);
> MODULE_AUTHOR("Alain L. Knaff");
> +MODULE_DESCRIPTION("Normal floppy disk support");
> MODULE_LICENSE("GPL");
>
> /* This doesn't actually get used other than for module information */
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240602-md-block-floppy-1984117350ec
>

Reviewed-by: Denis Efremov <[email protected]>

Thanks,
Denis