The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
data. Select it in the Kconfig.
Signed-off-by: Bin Meng <[email protected]>
---
drivers/mtd/spi-nor/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
index bfdfb1e..e998800 100644
--- a/drivers/mtd/spi-nor/Kconfig
+++ b/drivers/mtd/spi-nor/Kconfig
@@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
depends on X86
select SPI_INTEL_SPI
+ select LPC_ICH
help
This enables platform support for the Intel PCH/PCU SPI
controller in master mode. This controller is present in modern
--
2.9.2
On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote:
> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
> data. Select it in the Kconfig.
>
> Signed-off-by: Bin Meng <[email protected]>
> ---
>
> drivers/mtd/spi-nor/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
> index bfdfb1e..e998800 100644
> --- a/drivers/mtd/spi-nor/Kconfig
> +++ b/drivers/mtd/spi-nor/Kconfig
> @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
> depends on X86
> select SPI_INTEL_SPI
> + select LPC_ICH
How about
depends on X86 && LPC_ICH
instead?
Hi Mika,
On Fri, Aug 25, 2017 at 6:40 PM, Mika Westerberg
<[email protected]> wrote:
> On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote:
>> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
>> data. Select it in the Kconfig.
>>
>> Signed-off-by: Bin Meng <[email protected]>
>> ---
>>
>> drivers/mtd/spi-nor/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>> index bfdfb1e..e998800 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
>> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> depends on X86
>> select SPI_INTEL_SPI
>> + select LPC_ICH
>
> How about
>
> depends on X86 && LPC_ICH
>
> instead?
Other LPC_ICH users (like gpio, watchdog) use the 'select' logic, so I
would prefer to keep things consistent.
Regards,
Bin
On 25.08.2017 12:40, Mika Westerberg wrote:
> On Fri, Aug 25, 2017 at 01:12:51AM -0700, Bin Meng wrote:
>> The Intel SPI-NOR driver is dependent on LPC_ICH to get the platform
>> data. Select it in the Kconfig.
>>
>> Signed-off-by: Bin Meng <[email protected]>
>> ---
>>
>> drivers/mtd/spi-nor/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/Kconfig b/drivers/mtd/spi-nor/Kconfig
>> index bfdfb1e..e998800 100644
>> --- a/drivers/mtd/spi-nor/Kconfig
>> +++ b/drivers/mtd/spi-nor/Kconfig
>> @@ -93,6 +93,7 @@ config SPI_INTEL_SPI_PLATFORM
>> tristate "Intel PCH/PCU SPI flash platform driver" if EXPERT
>> depends on X86
>> select SPI_INTEL_SPI
>> + select LPC_ICH
>
> How about
>
> depends on X86 && LPC_ICH
>
> instead?
I prefer Bin's version, as with your patch, the MTD SPI driver will
not be "seen" / selectable, as long as the LPC_ICH support is not
enabled. I've been hunting such dependencies myself a few times and
find them unnecessary burden.
Thanks,
Stefan
On Fri, Aug 25, 2017 at 08:11:54PM +0800, Bin Meng wrote:
> Other LPC_ICH users (like gpio, watchdog) use the 'select' logic, so I
> would prefer to keep things consistent.
Fair enough.
Acked-by: Mika Westerberg <[email protected]>