2023-04-19 11:46:11

by Hari Nagalla

[permalink] [raw]
Subject: [PATCH 2/2] arm64: defconfig: enable TI K3 R5 and DSP remote proc drivers

Enable Cortex R5 and TI DSP (C66x,C71x) remote proc drivers as modules
for K3 platforms.

Signed-off-by: Hari Nagalla <[email protected]>
---
arch/arm64/configs/defconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 52da7bad8ef9..d8e0ae85485f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1173,6 +1173,8 @@ CONFIG_ARM_SMMU_V3=y
CONFIG_MTK_IOMMU=y
CONFIG_QCOM_IOMMU=y
CONFIG_REMOTEPROC=y
+CONFIG_TI_K3_R5_REMOTEPROC=m
+CONFIG_TI_K3_DSP_REMOTEPROC=m
CONFIG_MTK_SCP=m
CONFIG_QCOM_Q6V5_ADSP=m
CONFIG_QCOM_Q6V5_MSS=m
--
2.34.1


2023-04-19 11:48:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: defconfig: enable TI K3 R5 and DSP remote proc drivers

On 19/04/2023 13:39, Hari Nagalla wrote:
> Enable Cortex R5 and TI DSP (C66x,C71x) remote proc drivers as modules
> for K3 platforms.
>
> Signed-off-by: Hari Nagalla <[email protected]>

Why two separate patches for simple defconfig change?

Best regards,
Krzysztof

2023-04-19 11:56:25

by Hari Nagalla

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: defconfig: enable TI K3 R5 and DSP remote proc drivers

On 4/19/23 06:43, Krzysztof Kozlowski wrote:
> Why two separate patches for simple defconfig change?
The intention is to separate commits for enabling mailbox driver from
remote proc drivers. The mailbox driver is used by the TI K3 system
controller interface (SCI) driver as well, which is independent of
remote proc drivers.

2023-04-19 12:52:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: defconfig: enable TI K3 R5 and DSP remote proc drivers

On 19/04/2023 13:52, Hari Nagalla wrote:
> On 4/19/23 06:43, Krzysztof Kozlowski wrote:
>> Why two separate patches for simple defconfig change?
> The intention is to separate commits for enabling mailbox driver from
> remote proc drivers. The mailbox driver is used by the TI K3 system
> controller interface (SCI) driver as well, which is independent of
> remote proc drivers.

Yeah, but why? This is simple defconfig change, just enabling drivers
for same platform. With such arguments are we going to enable all
drivers everywhere one-by-one?

Best regards,
Krzysztof

2023-04-20 08:55:27

by Hari Nagalla

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: defconfig: enable TI K3 R5 and DSP remote proc drivers

On 4/19/23 07:46, Krzysztof Kozlowski wrote:
> Yeah, but why? This is simple defconfig change, just enabling drivers
> for same platform. With such arguments are we going to enable all
> drivers everywhere one-by-one?
Ok. will coalesce both patches and resubmit.

Thanks