2019-03-31 22:55:11

by Will Cunningham

Subject: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

Removed unnecessary parentheses.`

Signed-off-by: Will Cunningham <[email protected]>
---
drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 0af5315d4357..da5d53a288f7 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
pcl818_alloc_dma(dev, it->options[2]);

/* use 1MHz or 10MHz oscilator */
- if ((it->options[3] == 0) || (it->options[3] == 10))
+ if (it->options[3] == 0 || it->options[3] == 10)
osc_base = I8254_OSC_BASE_10MHZ;
else
osc_base = I8254_OSC_BASE_1MHZ;
@@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
devpriv->ns_min = board->ns_min;
if (!board->is_818) {
/* extended PCL718 to 100kHz DAC */
- if ((it->options[6] == 1) || (it->options[6] == 100))
+ if (it->options[6] == 1 || it->options[6] == 100)
devpriv->ns_min = 10000;
}

@@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
s->maxdata = 0x0fff;
s->range_table = &range_unipolar5;
if (board->is_818) {
- if ((it->options[4] == 1) || (it->options[4] == 10))
+ if (it->options[4] == 1 || it->options[4] == 10)
s->range_table = &range_unipolar10;
if (it->options[4] == 2)
s->range_table = &range_unknown;
} else {
- if ((it->options[5] == 1) || (it->options[5] == 10))
+ if (it->options[5] == 1 || it->options[5] == 10)
s->range_table = &range_unipolar10;
if (it->options[5] == 2)
s->range_table = &range_unknown;
--
2.19.2

2019-04-01 06:05:03

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote:
> Removed unnecessary parentheses.`

Odd trailing character :(

>
> Signed-off-by: Will Cunningham <[email protected]>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 0af5315d4357..da5d53a288f7 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> pcl818_alloc_dma(dev, it->options[2]);
>
> /* use 1MHz or 10MHz oscilator */
> - if ((it->options[3] == 0) || (it->options[3] == 10))
> + if (it->options[3] == 0 || it->options[3] == 10)

No, please leave as-is. () are there for humans to read, and having to
always remember the order of operations is not something you ever want
to do.

I _REALLY_ hate this option of checkpatch :(

greg k-h

2019-04-01 07:54:17

by Mukesh Ojha

Subject: Re: [PATCH] Staging: comedi: drivers: pcl818: Fixed a coding style error.

On 4/1/2019 4:23 AM, Will Cunningham wrote:
> Removed unnecessary parentheses.`
Remove the extra character at the end.

Fix the above thing then you can take.

Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

>
> Signed-off-by: Will Cunningham <[email protected]>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 0af5315d4357..da5d53a288f7 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> pcl818_alloc_dma(dev, it->options[2]);
>
> /* use 1MHz or 10MHz oscilator */
> - if ((it->options[3] == 0) || (it->options[3] == 10))
> + if (it->options[3] == 0 || it->options[3] == 10)
> osc_base = I8254_OSC_BASE_10MHZ;
> else
> osc_base = I8254_OSC_BASE_1MHZ;
> @@ -1026,7 +1026,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> devpriv->ns_min = board->ns_min;
> if (!board->is_818) {
> /* extended PCL718 to 100kHz DAC */
> - if ((it->options[6] == 1) || (it->options[6] == 100))
> + if (it->options[6] == 1 || it->options[6] == 100)
> devpriv->ns_min = 10000;
> }
>
> @@ -1067,12 +1067,12 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> s->maxdata = 0x0fff;
> s->range_table = &range_unipolar5;
> if (board->is_818) {
> - if ((it->options[4] == 1) || (it->options[4] == 10))
> + if (it->options[4] == 1 || it->options[4] == 10)
> s->range_table = &range_unipolar10;
> if (it->options[4] == 2)
> s->range_table = &range_unknown;
> } else {
> - if ((it->options[5] == 1) || (it->options[5] == 10))
> + if (it->options[5] == 1 || it->options[5] == 10)
> s->range_table = &range_unipolar10;
> if (it->options[5] == 2)
> s->range_table = &range_unknown;