2011-03-22 11:57:48

by Viresh Kumar

Subject: [PATCH] dmaengine/dmatest: Pass timeout via module params

When we try to test all channels present on our controller together, some
channels of lower priority may be very slow as compared to others. If number of
transfers is unlimited, some channels may timeout and will not finish within 3
seconds. Thus, while doing such regress testing we may need to have higher value
of timeouts. This patch adds support for passing timeout value via module
parameters. Default value is 3 msec, a negative value means max timeout
possible.

Signed-off-by: Viresh Kumar <[email protected]>
---
drivers/dma/dmatest.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 5589358..99394bb 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -54,6 +54,11 @@ module_param(pq_sources, uint, S_IRUGO);
MODULE_PARM_DESC(pq_sources,
"Number of p+q source buffers (default: 3)");

+static int timeout = 3000;
+module_param(timeout, uint, S_IRUGO);
+MODULE_PARM_DESC(timeout, "Transfer Timeout in msec (default: 3000), \
+ Pass -1 for infinite timeout");
+
/*
* Initialization patterns. All bytes in the source buffer has bit 7
* set, all bytes in the destination buffer has bit 7 cleared.
@@ -294,7 +299,7 @@ static int dmatest_func(void *data)
dma_addr_t dma_srcs[src_cnt];
dma_addr_t dma_dsts[dst_cnt];
struct completion cmp;
- unsigned long tmo = msecs_to_jiffies(3000);
+ unsigned long tmo = msecs_to_jiffies(timeout);
u8 align = 0;

total_tests++;
--
1.7.2.2

2011-03-22 18:21:47

by Dan Williams

Subject: Re: [PATCH] dmaengine/dmatest: Pass timeout via module params

On Tue, Mar 22, 2011 at 4:57 AM, Viresh Kumar <[email protected]> wrote:
> When we try to test all channels present on our controller together, some
> channels of lower priority may be very slow as compared to others. If number of
> transfers is unlimited, some channels may timeout and will not finish within 3
> seconds. Thus, while doing such regress testing we may need to have higher value
> of timeouts. This patch adds support for passing timeout value via module
> parameters. Default value is 3 msec, a negative value means max timeout
> possible.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Applied, thanks.

--
Dan