2017-11-17 20:17:25

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] drm/sti: Handle return value of platform_get_irq_byname

platform_get_irq_byname() can fail here and we must check its return
value.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpu/drm/sti/sti_hdmi.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c
index 30f02d2..adabd41 100644
--- a/drivers/gpu/drm/sti/sti_hdmi.c
+++ b/drivers/gpu/drm/sti/sti_hdmi.c
@@ -1414,6 +1414,11 @@ static int sti_hdmi_probe(struct platform_device *pdev)
init_waitqueue_head(&hdmi->wait_event);

hdmi->irq = platform_get_irq_byname(pdev, "irq");
+ if (hdmi->irq < 0) {
+ DRM_ERROR("Cannot get HDMI irq\n");
+ ret = hdmi->irq;
+ goto release_adapter;
+ }

ret = devm_request_threaded_irq(dev, hdmi->irq, hdmi_irq,
hdmi_irq_thread, IRQF_ONESHOT, dev_name(dev), hdmi);
--
2.7.4


From 1586492247227996943@xxx Mon Dec 11 12:55:09 +0000 2017
X-GM-THRID: 1586492247227996943
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread