Changes in v2:
Collected Acked-by.
Drop cd-gpios for sdhci.
Add mmc-hs200-1_8v to eMMC.
Correct the spi max frequency.
Update model name and compatible.
Update regulator according to the schematic.
Chukun Pan (2):
dt-bindings: arm: rockchip: add Radxa ROCK 3C
arm64: dts: rockchip: Add Radxa ROCK 3C
.../devicetree/bindings/arm/rockchip.yaml | 5 +
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3566-rock-3c.dts | 750 ++++++++++++++++++
3 files changed, 756 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
--
2.25.1
The Radxa ROCK 3C is a similar board to the
Radxa ROCK 3A with the Rockchip RK3566 SoC.
Add devicetree binding documentation for it.
Signed-off-by: Chukun Pan <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 1bbbaf81134b..e04c213a0dee 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -799,6 +799,11 @@ properties:
- const: radxa,rock3a
- const: rockchip,rk3568
+ - description: Radxa ROCK 3C
+ items:
+ - const: radxa,rock-3c
+ - const: rockchip,rk3566
+
- description: Radxa ROCK 5A
items:
- const: radxa,rock-5a
--
2.25.1
On 28/04/2024 14:36, Chukun Pan wrote:
> The Radxa ROCK 3C is a similar board to the
> Radxa ROCK 3A with the Rockchip RK3566 SoC.
> Add devicetree binding documentation for it.
For future:
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
>
> Signed-off-by: Chukun Pan <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1bbbaf81134b..e04c213a0dee 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -799,6 +799,11 @@ properties:
> - const: radxa,rock3a
> - const: rockchip,rk3568
>
> + - description: Radxa ROCK 3C
There was some big renaming of these boards. I assume you are using
correct naming?
Best regards,
Krzysztof
Hello Krzysztof,
On 2024-04-28 18:37, Krzysztof Kozlowski wrote:
> On 28/04/2024 14:36, Chukun Pan wrote:
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 1bbbaf81134b..e04c213a0dee 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -799,6 +799,11 @@ properties:
>> - const: radxa,rock3a
>> - const: rockchip,rk3568
>>
>> + - description: Radxa ROCK 3C
>
> There was some big renaming of these boards. I assume you are using
> correct naming?
I can confirm that the naming above is fine.
On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> Changes in v2:
> Collected Acked-by.
> Drop cd-gpios for sdhci.
> Add mmc-hs200-1_8v to eMMC.
> Correct the spi max frequency.
> Update model name and compatible.
> Update regulator according to the schematic.
>
> Chukun Pan (2):
> dt-bindings: arm: rockchip: add Radxa ROCK 3C
> arm64: dts: rockchip: Add Radxa ROCK 3C
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3566-rock-3c.dts | 750 ++++++++++++++++++
> 3 files changed, 756 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts
>
> --
> 2.25.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3566-rock-3c.dtb' for [email protected]:
arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
>> The Radxa ROCK 3C is a similar board to the
>> Radxa ROCK 3A with the Rockchip RK3566 SoC.
>> Add devicetree binding documentation for it.
> For future:
>
> Please wrap commit message according to Linux coding style / submission
> process (neither too early nor over the limit)
Should I compress these three lines into two?
> There was some big renaming of these boards. I assume you are using
> correct naming?
According to the link below, the model name is now correct:
https://lore.kernel.org/lkml/[email protected]/
Thanks,
Chukun
--
2.25.1
On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> Changes in v2:
> Collected Acked-by.
> Drop cd-gpios for sdhci.
> Add mmc-hs200-1_8v to eMMC.
> Correct the spi max frequency.
> Update model name and compatible.
> Update regulator according to the schematic.
>
> [...]
Applied, thanks!
[1/2] dt-bindings: arm: rockchip: add Radxa ROCK 3C
commit: c0c153e341d2a82241bf0a0b78117ceeb29be3eb
[2/2] arm64: dts: rockchip: Add Radxa ROCK 3C
commit: ee219017ddb50be14c60d3cbe3e51ac0b2008d40
Best regards,
--
Heiko Stuebner <[email protected]>
Am Freitag, 3. Mai 2024, 13:38:19 CEST schrieb Heiko Stuebner:
> On Sun, 28 Apr 2024 20:36:16 +0800, Chukun Pan wrote:
> > Changes in v2:
> > Collected Acked-by.
> > Drop cd-gpios for sdhci.
> > Add mmc-hs200-1_8v to eMMC.
> > Correct the spi max frequency.
> > Update model name and compatible.
> > Update regulator according to the schematic.
> >
> > [...]
>
> Applied, thanks!
>
> [1/2] dt-bindings: arm: rockchip: add Radxa ROCK 3C
> commit: c0c153e341d2a82241bf0a0b78117ceeb29be3eb
> [2/2] arm64: dts: rockchip: Add Radxa ROCK 3C
> commit: ee219017ddb50be14c60d3cbe3e51ac0b2008d40
Forgot to add, I've dropped the rk809-sound node, as well as the sound-related
properties from the rk809 pmic that got flagged by the binding check
and which I could reproduce here too.
So please submit these as follow up patches, once the necessary changes
to the pmic to allow its codec use are merged.
Thanks
Heiko