2018-01-05 01:28:21

by Zhenzhong Duan

[permalink] [raw]
Subject: Re: [PATCH v2] tick/broadcast: Remove redundant code in tick_check_new_device()

Hi Maintainers,

Any comment for this v2?

Thanks
zduan
----- [email protected] wrote:

> There is no way a timer used as broadcast clockevent device is also
> used as
> percpu tick clockevent device currently.
>
> -v2: remove meaningless description suggested by tglx
>
> Signed-off-by: Zhenzhong Duan <[email protected]>
> ---
> kernel/time/tick-common.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
> index 49edc1c..9bcc866 100644
> --- a/kernel/time/tick-common.c
> +++ b/kernel/time/tick-common.c
> @@ -320,13 +320,8 @@ void tick_check_new_device(struct
> clock_event_device *newdev)
>
> /*
> * Replace the eventually existing device by the new
> - * device. If the current device is the broadcast device, do
> - * not give it back to the clockevents layer !
> + * device.
> */
> - if (tick_is_broadcast_device(curdev)) {
> - clockevents_shutdown(curdev);
> - curdev = NULL;
> - }
> clockevents_exchange_device(curdev, newdev);
> tick_setup_device(td, newdev, cpu, cpumask_of(cpu));
> if (newdev->features & CLOCK_EVT_FEAT_ONESHOT)
> --
> 1.7.3