2024-05-02 15:48:23

by Shi-Sheng Yang

[permalink] [raw]
Subject: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments

This patch fixes the spelling mistakes in comments.
The changes were generated using codespell and reviewed manually.

eariler -> earlier
greceful -> graceful

Signed-off-by: Shi-Sheng Yang <[email protected]>
---
net/mptcp/subflow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index 97ec44d1df30..0ac8d4850751 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -911,7 +911,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,
}

/* check for expected invariant - should never trigger, just help
- * catching eariler subtle bugs
+ * catching earlier subtle bugs
*/
WARN_ON_ONCE(child && *own_req && tcp_sk(child)->is_mptcp &&
(!mptcp_subflow_ctx(child) ||
@@ -1259,7 +1259,7 @@ static void mptcp_subflow_fail(struct mptcp_sock *msk, struct sock *ssk)
struct mptcp_subflow_context *subflow = mptcp_subflow_ctx(ssk);
unsigned long fail_tout;

- /* greceful failure can happen only on the MPC subflow */
+ /* graceful failure can happen only on the MPC subflow */
if (WARN_ON_ONCE(ssk != READ_ONCE(msk->first)))
return;

--
2.34.1



2024-05-04 10:58:41

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments

On Thu, May 02, 2024 at 11:47:40PM +0800, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful
>
> Signed-off-by: Shi-Sheng Yang <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2024-05-06 07:41:17

by Matthieu Baerts (NGI0)

[permalink] [raw]
Subject: Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments

Hi Shi-Sheng,

On 02/05/2024 17:47, Shi-Sheng Yang wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful

Thank you for the fix, it looks good to me:

Reviewed-by: Matthieu Baerts (NGI0) <[email protected]>

@Simon: many thanks for the previous review!

@Netdev maintainers: I think it is best to apply this patch -- and
similar ones -- directly in the Netdev tree, no need to have it first in
the MPTCP tree.

Cheers,
Matt
--
Sponsored by the NGI0 Core fund.


2024-05-07 02:50:44

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] [PATCH v2 net-next] mptcp: fix typos in comments

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Thu, 2 May 2024 23:47:40 +0800 you wrote:
> This patch fixes the spelling mistakes in comments.
> The changes were generated using codespell and reviewed manually.
>
> eariler -> earlier
> greceful -> graceful
>
> Signed-off-by: Shi-Sheng Yang <[email protected]>
>
> [...]

Here is the summary with links:
- [v2,net-next] mptcp: fix typos in comments
https://git.kernel.org/netdev/net-next/c/46a5d3abedbe

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html