2022-12-15 18:31:08

by Bjorn Helgaas

Subject: [PATCH 1/2] PCI: switchtec: Simplify switchtec_dma_mrpc_isr()

From: Bjorn Helgaas <[email protected]>

The "ret" variable in switchtec_dma_mrpc_isr() is superfluous. Remove it
and just return the value. No functional change intended.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/pci/switch/switchtec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 75be4fe22509..d7ae84070e29 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -1480,15 +1480,13 @@ static irqreturn_t switchtec_event_isr(int irq, void *dev)
static irqreturn_t switchtec_dma_mrpc_isr(int irq, void *dev)
{
struct switchtec_dev *stdev = dev;
- irqreturn_t ret = IRQ_NONE;

iowrite32(SWITCHTEC_EVENT_CLEAR |
SWITCHTEC_EVENT_EN_IRQ,
&stdev->mmio_part_cfg->mrpc_comp_hdr);
schedule_work(&stdev->mrpc_work);

- ret = IRQ_HANDLED;
- return ret;
+ return IRQ_HANDLED;
}

static int switchtec_init_isr(struct switchtec_dev *stdev)
--
2.25.1

2022-12-15 19:07:32

by Logan Gunthorpe

Subject: Re: [PATCH 1/2] PCI: switchtec: Simplify switchtec_dma_mrpc_isr()

On 2022-12-15 11:21, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> The "ret" variable in switchtec_dma_mrpc_isr() is superfluous. Remove it
> and just return the value. No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

Reviewed-by: Logan Gunthorpe <[email protected]>

Thanks,

Logan