2022-10-12 22:04:52

by Luca Weiss

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: msm8996: remove bogus ufs_variant node

This ufs_variant node seems to be a remnant from downstream devicetree.

As it doesn't seem to be used by anything upstream, remove it from the
dtsi.

Signed-off-by: Luca Weiss <[email protected]>
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c0a2baffa49d..87e9aef951ab 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1995,10 +1995,6 @@ ufshc: ufshc@624000 {
lanes-per-direction = <1>;
#reset-cells = <1>;
status = "disabled";
-
- ufs_variant {
- compatible = "qcom,ufs_variant";
- };
};

ufsphy: phy@627000 {
--
2.38.0


2022-10-12 22:36:32

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: remove bogus ufs_variant node

On Thu, 13 Oct 2022 at 00:56, Luca Weiss <[email protected]> wrote:
>
> This ufs_variant node seems to be a remnant from downstream devicetree.
>
> As it doesn't seem to be used by anything upstream, remove it from the
> dtsi.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ----
> 1 file changed, 4 deletions(-)


Reviewed-by: Dmitry Baryshkov <[email protected]>


--
With best wishes
Dmitry

2022-10-12 23:58:26

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: remove bogus ufs_variant node

On 2022-10-12 23:56, Luca Weiss wrote:
> This ufs_variant node seems to be a remnant from downstream devicetree.
Totally [1]


Reviewed-by: Konrad Dybcio <[email protected]>

Konrad

[1]
https://android.googlesource.com/kernel/msm/+/dff8939cd46ee6b95535d68c54b8bd05ddb6bc1e
>
> As it doesn't seem to be used by anything upstream, remove it from the
> dtsi.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/msm8996.dtsi | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c0a2baffa49d..87e9aef951ab 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1995,10 +1995,6 @@ ufshc: ufshc@624000 {
> lanes-per-direction = <1>;
> #reset-cells = <1>;
> status = "disabled";
> -
> - ufs_variant {
> - compatible = "qcom,ufs_variant";
> - };
> };
>
> ufsphy: phy@627000 {

2022-10-13 14:56:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: remove bogus ufs_variant node

On 12/10/2022 17:56, Luca Weiss wrote:
> This ufs_variant node seems to be a remnant from downstream devicetree.
>
> As it doesn't seem to be used by anything upstream, remove it from the
> dtsi.
>
> Signed-off-by: Luca Weiss <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-10-18 03:21:37

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: msm8996: remove bogus ufs_variant node

On Wed, 12 Oct 2022 23:56:13 +0200, Luca Weiss wrote:
> This ufs_variant node seems to be a remnant from downstream devicetree.
>
> As it doesn't seem to be used by anything upstream, remove it from the
> dtsi.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: msm8996: remove bogus ufs_variant node
commit: 54a8d54b51839df625d376eb8684e51ceec08629

Best regards,
--
Bjorn Andersson <[email protected]>