2021-01-20 14:58:24

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v1 0/7] devicetree fixes for Protonic and Plymovent boards

Oleksij Rempel (7):
dt-bindings: display: simple: add Innolux G070Y2-T02 panel
drm: panel-simple: Add support for the Innolux G070Y2-T02 panel
ARM: dts: imx6dl-prtvt7: Add display and panel nodes
ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node
ARM: dts: imx6dl-prtvt7: Remove backlight enable gpio
ARM: dts: imx6dl-prtvt7: fix PWM cell count for the backlight node.
ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties

.../bindings/display/panel/panel-simple.yaml | 2 +
arch/arm/boot/dts/imx6dl-plym2m.dts | 2 -
arch/arm/boot/dts/imx6dl-prtvt7.dts | 79 ++++++++++++++++---
drivers/gpu/drm/panel/panel-simple.c | 16 ++++
4 files changed, 86 insertions(+), 13 deletions(-)

--
2.30.0


2021-01-20 14:59:18

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v1 7/7] ARM: dts: imx6dl-plym2m: remove touchscreen-size-* properties

Remove touchscreen-size-* properties. This values are not correct, event if it
works with ts_test tool, it fails to work properly with weston.
And the real range of values reported by the driver (or measured by the
controller) is close to max values and may change with time on resistive
panels. So, it make no sense to keep this values in the device tree.

Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm/boot/dts/imx6dl-plym2m.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx6dl-plym2m.dts b/arch/arm/boot/dts/imx6dl-plym2m.dts
index 4d0d3d3386af..c97274f0df07 100644
--- a/arch/arm/boot/dts/imx6dl-plym2m.dts
+++ b/arch/arm/boot/dts/imx6dl-plym2m.dts
@@ -138,8 +138,6 @@ touchscreen@0 {
interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;

- touchscreen-size-x = <800>;
- touchscreen-size-y = <480>;
touchscreen-inverted-x;
touchscreen-inverted-y;
touchscreen-max-pressure = <4095>;
--
2.30.0

2021-01-20 15:35:40

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

Add touchscreen support to the Protonic VT7 board.

Co-Developed-by: Robin van der Gracht <[email protected]>
Signed-off-by: Robin van der Gracht <[email protected]>
Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
index d9cb1e41cc10..63ae2065834c 100644
--- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
+++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
@@ -266,6 +266,26 @@ &ecspi2 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_ecspi2>;
status = "okay";
+
+ touchscreen@0 {
+ compatible = "ti,tsc2046";
+ reg = <0>;
+ pinctrl-0 = <&pinctrl_tsc>;
+ pinctrl-names ="default";
+ spi-max-frequency = <100000>;
+ interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
+ pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
+
+ touchscreen-inverted-x;
+ touchscreen-inverted-y;
+ touchscreen-max-pressure = <4095>;
+
+ ti,vref-delay-usecs = /bits/ 16 <100>;
+ ti,x-plate-ohms = /bits/ 16 <800>;
+ ti,y-plate-ohms = /bits/ 16 <300>;
+
+ wakeup-source;
+ };
};

&i2c1 {
--
2.30.0

2021-01-20 17:33:33

by Robin van der Gracht

[permalink] [raw]
Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

On 2021-01-20 15:22, Oleksij Rempel wrote:
> Add touchscreen support to the Protonic VT7 board.
>
> Co-Developed-by: Robin van der Gracht <[email protected]>
> Signed-off-by: Robin van der Gracht <[email protected]>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> index d9cb1e41cc10..63ae2065834c 100644
> --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -266,6 +266,26 @@ &ecspi2 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_ecspi2>;
> status = "okay";
> +
> + touchscreen@0 {
> + compatible = "ti,tsc2046";
> + reg = <0>;
> + pinctrl-0 = <&pinctrl_tsc>;
> + pinctrl-names ="default";
> + spi-max-frequency = <100000>;
> + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> +
> + touchscreen-inverted-x;
> + touchscreen-inverted-y;

Please remove both inverted properties since it's not inverted.

> + touchscreen-max-pressure = <4095>;
> +
> + ti,vref-delay-usecs = /bits/ 16 <100>;
> + ti,x-plate-ohms = /bits/ 16 <800>;
> + ti,y-plate-ohms = /bits/ 16 <300>;
> +
> + wakeup-source;
> + };
> };
>
> &i2c1 {

Robin