2023-01-19 10:09:10

by ye.xingchen

[permalink] [raw]
Subject: [PATCH] i2c: aspeed: Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/i2c/busses/i2c-aspeed.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index c64c381b69b7..d3c99c5b3247 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -979,15 +979,13 @@ static int aspeed_i2c_probe_bus(struct platform_device *pdev)
const struct of_device_id *match;
struct aspeed_i2c_bus *bus;
struct clk *parent_clk;
- struct resource *res;
int irq, ret;

bus = devm_kzalloc(&pdev->dev, sizeof(*bus), GFP_KERNEL);
if (!bus)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- bus->base = devm_ioremap_resource(&pdev->dev, res);
+ bus->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(bus->base))
return PTR_ERR(bus->base);

--
2.25.1


2023-01-20 03:04:23

by Andrew Jeffery

[permalink] [raw]
Subject: Re: [PATCH] i2c: aspeed: Use devm_platform_get_and_ioremap_resource()



On Thu, 19 Jan 2023, at 19:45, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Reviewed-by: Andrew Jeffery <[email protected]>

2023-01-20 10:11:50

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] i2c: aspeed: Use devm_platform_get_and_ioremap_resource()

On Thu, Jan 19, 2023 at 05:15:31PM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (388.00 B)
signature.asc (849.00 B)
Download all attachments