2019-06-20 05:32:03

by Aliasgar Surti

Subject: [PATCH 1/1] staging: media: fix style problem

From: Aliasgar Surti <[email protected]>

checkpatch reported "WARNING: line over 80 characters".
This patch fixes the warning for file davinci_vpfe/dm365_isif.c

Signed-off-by: Aliasgar Surti <[email protected]>
---
drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
index 46fd818..e9c8de1 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
@@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
#define DM365_ISIF_MAX_CLVSV 0x1fff
#define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff

-static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
+static int
+isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
{
int err = -EINVAL;

@@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
return isif_validate_bclamp_params(&params->bclamp);
}

-static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
+static int isif_set_params(struct v4l2_subdev *sd,
+ const struct vpfe_isif_raw_config *params)
{
struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
int ret = -EINVAL;
--
2.7.4

2019-06-20 21:27:06

by André Almeida

Subject: Re: [PATCH 1/1] staging: media: fix style problem

Hello Alisgar,

On 6/20/19 2:31 AM, Aliasgar Surti wrote:
> From: Aliasgar Surti <[email protected]>
>
> checkpatch reported "WARNING: line over 80 characters".
> This patch fixes the warning for file davinci_vpfe/dm365_isif.c
>
> Signed-off-by: Aliasgar Surti <[email protected]>
> ---
> drivers/staging/media/davinci_vpfe/dm365_isif.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.c b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> index 46fd818..e9c8de1 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_isif.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_isif.c
> @@ -532,7 +532,8 @@ static int isif_validate_dfc_params(const struct vpfe_isif_dfc *dfc)
> #define DM365_ISIF_MAX_CLVSV 0x1fff
> #define DM365_ISIF_MAX_HEIGHT_BLACK_REGION 0x1fff
>
> -static int isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> +static int
> +isif_validate_bclamp_params(const struct vpfe_isif_black_clamp *bclamp)
> {
> int err = -EINVAL;
>
> @@ -593,7 +594,8 @@ isif_validate_raw_params(const struct vpfe_isif_raw_config *params)
> return isif_validate_bclamp_params(&params->bclamp);
> }
>
> -static int isif_set_params(struct v4l2_subdev *sd, const struct vpfe_isif_raw_config *params)
> +static int isif_set_params(struct v4l2_subdev *sd,
> + const struct vpfe_isif_raw_config *params)
> {
> struct vpfe_isif_device *isif = v4l2_get_subdevdata(sd);
> int ret = -EINVAL;


When you resend a patch with some modifications you have done after
receiving some feedback, don't forget to increase the version of your
patch . One can do this by adding the `-v2` flag at `git format-patch`
command. It is also a good practice to changelog what modifications you
did bellow the `---` mark.

Have a look at this v3[1]. And please read "Revising your patches"[2]
for a complete documentation.

Good hacking!
    André

[1] https://patchwork.kernel.org/patch/10999271/
[2] https://kernelnewbies.org/FirstKernelPatch