2022-10-15 01:27:43

by Stephen Boyd

Subject: [PATCH 1/2] soc: qcom: cmd-db: Mark device as having no PM support

This driver purely exposes information from memory to the kernel. Let's
mark it as not having any device PM functionality, so that during
suspend we skip even trying to call a suspend function on this device.
This clears up suspend logs more than anything else, but it also shaves
a few cycles off suspend.

Cc: Konrad Dybcio <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/soc/qcom/cmd-db.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index 629a7188b576..33856abd560c 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -338,6 +338,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)

debugfs_create_file("cmd-db", 0400, NULL, NULL, &cmd_db_debugfs_ops);

+ device_set_pm_not_required(&pdev->dev);
+
return 0;
}


base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
--
https://chromeos.dev

2022-10-15 11:32:08

by Konrad Dybcio

Subject: Re: [PATCH 1/2] soc: qcom: cmd-db: Mark device as having no PM support

On 15.10.2022 02:46, Stephen Boyd wrote:
> This driver purely exposes information from memory to the kernel. Let's
> mark it as not having any device PM functionality, so that during
> suspend we skip even trying to call a suspend function on this device.
> This clears up suspend logs more than anything else, but it also shaves
> a few cycles off suspend.
>
> Cc: Konrad Dybcio <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/soc/qcom/cmd-db.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 629a7188b576..33856abd560c 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -338,6 +338,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)
>
> debugfs_create_file("cmd-db", 0400, NULL, NULL, &cmd_db_debugfs_ops);
>
> + device_set_pm_not_required(&pdev->dev);
> +
> return 0;
> }
>
>
> base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f