2018-02-16 14:38:51

by SF Markus Elfring

Subject: [PATCH 0/2] cpufreq/PowerNow-K8: Adjustments for two function implementations

From: Markus Elfring <[email protected]>
Date: Thu, 15 Feb 2018 20:24:26 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation in three functions
Delete an unnecessary return statement in two functions

drivers/cpufreq/powernow-k8.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)

--
2.16.1

2018-02-16 14:40:20

by SF Markus Elfring

Subject: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions

From: Markus Elfring <[email protected]>
Date: Thu, 15 Feb 2018 20:14:32 +0100

The script "checkpatch.pl" pointed information out like the following.

WARNING: void function return statements are not generally useful

Thus remove such a statement in the affected functions.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/cpufreq/powernow-k8.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index 460bf22a8a2b..782a8c2a359d 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -122,14 +122,12 @@ static int query_current_values_with_pending_wait(struct powernow_k8_data *data)
static void count_off_irt(struct powernow_k8_data *data)
{
udelay((1 << data->irt) * 10);
- return;
}

/* the voltage stabilization time */
static void count_off_vst(struct powernow_k8_data *data)
{
udelay(data->vstable * VST_UNITS_20US);
- return;
}

/* need to init the control msr to a safe value (for each cpu) */
--
2.16.1

2018-02-16 16:45:51

by SF Markus Elfring

Subject: [PATCH 1/2] cpufreq: powernow-k8: Delete an error message for a failed memory allocation in three functions

From: Markus Elfring <[email protected]>
Date: Thu, 15 Feb 2018 20:00:23 +0100

Omit an extra message for a memory allocation failure in these functions.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/cpufreq/powernow-k8.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index b01e31db5f83..460bf22a8a2b 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -591,10 +591,8 @@ static int fill_powernow_table(struct powernow_k8_data *data,

powernow_table = kzalloc((sizeof(*powernow_table)
* (data->numps + 1)), GFP_KERNEL);
- if (!powernow_table) {
- pr_err("powernow_table memory alloc failure\n");
+ if (!powernow_table)
return -ENOMEM;
- }

for (j = 0; j < data->numps; j++) {
int freq;
@@ -760,10 +758,8 @@ static int powernow_k8_cpu_init_acpi(struct powernow_k8_data *data)
/* fill in data->powernow_table */
powernow_table = kzalloc((sizeof(*powernow_table)
* (data->acpi_data.state_count + 1)), GFP_KERNEL);
- if (!powernow_table) {
- pr_debug("powernow_table memory alloc failure\n");
+ if (!powernow_table)
goto err_out;
- }

/* fill in data */
data->numps = data->acpi_data.state_count;
@@ -1042,10 +1038,8 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)
return -ENODEV;

data = kzalloc(sizeof(*data), GFP_KERNEL);
- if (!data) {
- pr_err("unable to alloc powernow_k8_data\n");
+ if (!data)
return -ENOMEM;
- }

data->cpu = pol->cpu;

--
2.16.1

2018-02-19 03:45:15

by Viresh Kumar

Subject: Re: [PATCH 1/2] cpufreq: powernow-k8: Delete an error message for a failed memory allocation in three functions

On 15-02-18, 20:29, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Thu, 15 Feb 2018 20:00:23 +0100
>
> Omit an extra message for a memory allocation failure in these functions.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/cpufreq/powernow-k8.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2018-02-19 03:46:03

by Viresh Kumar

Subject: Re: [PATCH 2/2] cpufreq: powernow-k8: Delete an unnecessary return statement in two functions

On 15-02-18, 20:30, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Thu, 15 Feb 2018 20:14:32 +0100
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: void function return statements are not generally useful
>
> Thus remove such a statement in the affected functions.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/cpufreq/powernow-k8.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 460bf22a8a2b..782a8c2a359d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -122,14 +122,12 @@ static int query_current_values_with_pending_wait(struct powernow_k8_data *data)
> static void count_off_irt(struct powernow_k8_data *data)
> {
> udelay((1 << data->irt) * 10);
> - return;
> }
>
> /* the voltage stabilization time */
> static void count_off_vst(struct powernow_k8_data *data)
> {
> udelay(data->vstable * VST_UNITS_20US);
> - return;
> }
>
> /* need to init the control msr to a safe value (for each cpu) */

Acked-by: Viresh Kumar <[email protected]>

--
viresh