2023-02-16 00:49:22

by Jesper Juhl

[permalink] [raw]
Subject: [Patch] [drivers/net] Remove unneeded version.h includes

From bb51298e935ded65d79cb0d489d38f867a22a092 Mon Sep 17 00:00:00 2001
From: Jesper Juhl <[email protected]>
Date: Mon, 13 Feb 2023 02:46:58 +0100
Subject: [PATCH 02/12] [drivers/net] Remove unneeded version.h includes
pointed out by 'make versioncheck'

Signed-off-by: Jesper Juhl <[email protected]>
---
drivers/net/ethernet/qlogic/qede/qede.h | 1 -
drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index f90dcfe9ee68..6ff1bd48d2aa 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -7,7 +7,6 @@
#ifndef _QEDE_H_
#define _QEDE_H_
#include <linux/compiler.h>
-#include <linux/version.h>
#include <linux/workqueue.h>
#include <linux/netdevice.h>
#include <linux/interrupt.h>
diff --git a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
index 8034d812d5a0..374a86b875a3 100644
--- a/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
+++ b/drivers/net/ethernet/qlogic/qede/qede_ethtool.c
@@ -4,7 +4,6 @@
* Copyright (c) 2019-2020 Marvell International Ltd.
*/

-#include <linux/version.h>
#include <linux/types.h>
#include <linux/netdevice.h>
#include <linux/etherdevice.h>
--
2.39.2



2023-02-16 06:06:52

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [Patch] [drivers/net] Remove unneeded version.h includes

On Thu, 16 Feb 2023 01:48:50 +0100 (CET) Jesper Juhl wrote:
> From: Jesper Juhl <[email protected]>
> To: [email protected]
> cc: [email protected], "David S. Miller" <[email protected]>
> Subject: [Patch] [drivers/net] Remove unneeded version.h includes
> Date: Thu, 16 Feb 2023 01:48:50 +0100 (CET)
> User-Agent: Alpine 2.26 (LNX 649 2022-06-02)
>
> From bb51298e935ded65d79cb0d489d38f867a22a092 Mon Sep 17 00:00:00 2001
> From: Jesper Juhl <[email protected]>
> Date: Mon, 13 Feb 2023 02:46:58 +0100
> Subject: [PATCH 02/12] [drivers/net] Remove unneeded version.h includes
> pointed out by 'make versioncheck'

You have the headers twice and no commit message.
Maybe try git send-email?